Differential D7264

vault: add monitoring of bundle downloads
ClosedPublic
Actions

Authored by olasd on Feb 28 2022, 6:21 PM.

Details

Reviewers

vlorentz

Maniphest Tasks

T3983: Add monitoring of vault bundle downloads

Commits

rDICPc698de271141: vault: add monitoring of bundle downloads

Summary

This adds a download step to the vault end to end check once the API
claims that the cooking was successful.

The download step checks:

that the fetch_url is present
that the status code is successful
that the response is not empty

Related to T3983

Test Plan

new test scenarios added for the new failure modes

Diff Detail

Repository

rDICP Icinga plugins

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27195
Build 42538: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42537: arc lint + arc unit

Event Timeline

olasd created this revision.Feb 28 2022, 6:21 PM

Build has FAILED

Patch application report for D7264 (id=26322)

Rebasing onto 26a98cae80...

Current branch diff-target is up to date.

Changes applied before test

commit a1423a8715ded457e29feb890eb123a921ebd8b3
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Feb 28 18:18:54 2022 +0100

    vault: add monitoring of bundle downloads
    
    This adds a download step to the vault end to end check once the API
    claims that the cooking was successful.
    
    The download step checks:
     - that the fetch_url is present
     - that the status code is successful
     - that the response is not empty

Link to build: https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/46/
See console output for more information: https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/46/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 28 2022, 6:22 PM

Harbormaster failed remote builds in B27195: Diff 26322!

Looks like we need to release swh.deposit with D7265 for these to become green.

olasd mentioned this in D7295: vault: Check bundle download from the public API..Mar 4 2022, 3:43 PM

olasd mentioned this in T4000: vault monitoring: check bundles can be downloaded.

Build is green

Patch application report for D7264 (id=26322)

Rebasing onto 27a2ef97c1...

First, rewinding head to replay your work on top of it...
Applying: vault: add monitoring of bundle downloads

Changes applied before test

commit 617c0d81381446d059c82330031968ca96413143
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Feb 28 18:18:54 2022 +0100

    vault: add monitoring of bundle downloads
    
    This adds a download step to the vault end to end check once the API
    claims that the cooking was successful.
    
    The download step checks:
     - that the fetch_url is present
     - that the status code is successful
     - that the response is not empty

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/55/ for more details.

Harbormaster completed remote builds in B27195: Diff 26322.Mar 4 2022, 3:49 PM

olasd requested review of this revision.Mar 4 2022, 3:49 PM

vlorentz accepted this revision.Mar 4 2022, 3:59 PM

This revision is now accepted and ready to land.Mar 4 2022, 3:59 PM

rebase

Build is green

Patch application report for D7264 (id=26405)

Rebasing onto 27a2ef97c1...

Current branch diff-target is up to date.

Changes applied before test

commit c698de271141c4dc45570e2b7d8a2d78fa02fd5b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Feb 28 18:18:54 2022 +0100

    vault: add monitoring of bundle downloads
    
    This adds a download step to the vault end to end check once the API
    claims that the cooking was successful.
    
    The download step checks:
     - that the fetch_url is present
     - that the status code is successful
     - that the response is not empty

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/57/ for more details.

Harbormaster completed remote builds in B27292: Diff 26405.Mar 4 2022, 4:02 PM

Closed by commit rDICPc698de271141: vault: add monitoring of bundle downloads (authored by olasd). · Explain WhyMar 4 2022, 4:02 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDICPc698de271141: vault: add monitoring of bundle downloads.

olasd mentioned this in D7297: Rename dir_id to DIR_ID.Mar 4 2022, 4:03 PM

olasd mentioned this in D7298: vault: Open the beginning of the tarball to check it makes sense..