Differential D7240

test_migrations.py
ClosedPublic
Actions

Authored by vlorentz on Feb 24 2022, 12:04 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP8a7e0832641b: Move tests_migration/test_migrations.py to tests/test_migrations.py

Summary

This fixes crashes when running 'pytest -k migration', because swh/deposit/tests_migration/
lacks a conftest to initialize the database.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 24 2022, 12:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 24 2022, 12:04 PM

Build is green

Patch application report for D7240 (id=26249)

Rebasing onto ccff46762b...

First, rewinding head to replay your work on top of it...
Applying: Move tests_migration/test_migrations.py to tests/test_migrations.py

Changes applied before test

commit c1a83c22543527fe1568bd21d316ff914d239445
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 24 12:04:03 2022 +0100

    Move tests_migration/test_migrations.py to tests/test_migrations.py
    
    This fixes crashes when running 'pytest -k migration', because swh/deposit/tests_migration/
    lacks a conftest to initialize the database.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/758/ for more details.

Harbormaster completed remote builds in B27121: Diff 26249.Feb 24 2022, 12:12 PM

vlorentz requested review of this revision.Feb 24 2022, 12:12 PM

lgtm

This revision is now accepted and ready to land.Feb 24 2022, 3:39 PM

rebase

Build is green

Patch application report for D7240 (id=26299)

Rebasing onto ccff46762b...

Current branch diff-target is up to date.

Changes applied before test

commit 8a7e0832641bda3b4c445793cfb92e3de6c5947e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 24 12:04:03 2022 +0100

    Move tests_migration/test_migrations.py to tests/test_migrations.py
    
    This fixes crashes when running 'pytest -k migration', because swh/deposit/tests_migration/
    lacks a conftest to initialize the database.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/780/ for more details.

Harbormaster completed remote builds in B27172: Diff 26299.Feb 28 2022, 10:27 AM

Closed by commit rDDEP8a7e0832641b: Move tests_migration/test_migrations.py to tests/test_migrations.py (authored by vlorentz). · Explain WhyFeb 28 2022, 11:01 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP8a7e0832641b: Move tests_migration/test_migrations.py to tests/test_migrations.py.