Page MenuHomeSoftware Heritage

Remove dependency on xmltodict
ClosedPublic

Authored by vlorentz on Feb 24 2022, 11:10 AM.

Details

Summary

We don't have much use for it anymore, let's use ElementTree everywhere
for consistency.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7237 (id=26233)

Rebasing onto cf92b5f2fe...

Current branch diff-target is up to date.
Changes applied before test
commit 2e901514c9f0ad382cf96bcfb2328c0cfe0a8fbf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 24 11:10:43 2022 +0100

    Remove dependency on xmltodict
    
    We don't have much use for it anymore, let's use ElementTree everywhere
    for consistency.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/754/ for more details.

ardumont added a subscriber: ardumont.

Thanks. I thought we were done with it already.

You can land, i'm still reworking test in the other diff you accepted.

This revision is now accepted and ready to land.Feb 24 2022, 11:44 AM

Thanks. I thought we were done with it already.

Only in parts it needed to process namespaces, because they were the ones to crash

This revision was landed with ongoing or failed builds.Feb 24 2022, 11:45 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7237 (id=26245)

Rebasing onto f520d976f4...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-756-D7237.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/756/ for more details.