Add type annotations, and fix issues found by mypy
ClosedPublic
Actions

Authored by vlorentz on Feb 10 2022, 3:36 PM.

Details

Reviewers

Alphare
ardumont

Group Reviewers

Reviewers

Commits

rDLDBZR8bcabc103211: Add type annotations, and fix issues found by mypy

Summary

The issues weren't noticed before because mypy does not analyze
functions without an annotation in their signature.

Diff Detail

Repository

rDLDBZR BZR loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 10 2022, 3:36 PM

Build is green

Patch application report for D7148 (id=25909)

Rebasing onto 0ffc124709...

Current branch diff-target is up to date.

Changes applied before test

commit 8bcabc10321102c532cfbd1b34ae3b8ee8f4c773
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 10 15:35:24 2022 +0100

    Add type annotations, and fix issues found by mypy
    
    The issues weren't noticed before because mypy does not analyze
    functions without an annotation in their signature.

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/41/ for more details.

Harbormaster completed remote builds in B26754: Diff 25909.Feb 10 2022, 3:41 PM

vlorentz requested review of this revision.Feb 10 2022, 3:41 PM

ardumont accepted this revision.Feb 10 2022, 4:04 PM

This revision is now accepted and ready to land.Feb 10 2022, 4:04 PM

Alphare accepted this revision.Feb 10 2022, 4:18 PM

Closed by commit rDLDBZR8bcabc103211: Add type annotations, and fix issues found by mypy (authored by vlorentz). · Explain WhyFeb 10 2022, 4:21 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBZR8bcabc103211: Add type annotations, and fix issues found by mypy.