Page MenuHomeSoftware Heritage

Add type annotations, and fix issues found by mypy
ClosedPublic

Authored by vlorentz on Feb 10 2022, 3:36 PM.

Details

Summary

The issues weren't noticed before because mypy does not analyze
functions without an annotation in their signature.

Diff Detail

Repository
rDLDBZR BZR loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26754
Build 41832: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41831: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7148 (id=25909)

Rebasing onto 0ffc124709...

Current branch diff-target is up to date.
Changes applied before test
commit 8bcabc10321102c532cfbd1b34ae3b8ee8f4c773
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 10 15:35:24 2022 +0100

    Add type annotations, and fix issues found by mypy
    
    The issues weren't noticed before because mypy does not analyze
    functions without an annotation in their signature.

See https://jenkins.softwareheritage.org/job/DLDBZR/job/tests-on-diff/41/ for more details.

This revision is now accepted and ready to land.Feb 10 2022, 4:04 PM