Move visit date helper from hg loader to core
ClosedPublic
Actions

Authored by Alphare on Feb 8 2022, 10:06 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE98ed83349c08: Move visit date helper from hg loader to core

Summary

There will be a related patch for the hg and the bzr loaders

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26639
Build 41658: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41657: arc lint + arc unit

Event Timeline

Alphare created this revision.Feb 8 2022, 10:06 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2022, 10:06 AM

Build is green

Patch application report for D7114 (id=25794)

Rebasing onto b3579ed07b...

Current branch diff-target is up to date.

Changes applied before test

commit 0184217e2dd3af6e5cd92f2cbb7ddca02a580581
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:03:09 2022 +0100

    Move visit date helper from hg loader to core
    
    There will be a related patch for the hg and the bzr loaders

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/690/ for more details.

Harbormaster completed remote builds in B26638: Diff 25794.Feb 8 2022, 10:08 AM

Alphare requested review of this revision.Feb 8 2022, 10:08 AM

Add tests

Build is green

Patch application report for D7114 (id=25795)

Rebasing onto b3579ed07b...

Current branch diff-target is up to date.

Changes applied before test

commit 98ed83349c085eeb4bb6870106bbe8b9410bfaa5
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:03:09 2022 +0100

    Move visit date helper from hg loader to core
    
    There will be a related patch for the hg and the bzr loaders

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/691/ for more details.

Harbormaster completed remote builds in B26639: Diff 25795.Feb 8 2022, 10:13 AM

I see this is used in swh/loader/mercurial/tasks.py. Why do we need to handle this many formats? The argument is be generated by us, so we should be able to make it consistent

Alphare added a child revision: D7116: Use the now refactored visit date util from core.Feb 8 2022, 10:16 AM

In D7114#185083, @vlorentz wrote:

I see this is used in swh/loader/mercurial/tasks.py. Why do we need to handle this many formats? The argument is be generated by us, so we should be able to make it consistent

This may be some leftover over-engineering, I'd be happy to drop it, but I have no real insight as to why this is/used to be necessary if at all.

It must be related to the use of this kind of date though cli (when the initial code was within the scope of the loader but now it's no longer the case).

So this is highly possible the str and the "now" version can be dropped (since we don't use those kind of tasks through cli).

(I'm wondering whether this goes in swh-loader-core or swh-core though.)

Let's just land this as is for now.

This revision is now accepted and ready to land.Feb 8 2022, 10:35 AM

Closed by commit rDLDBASE98ed83349c08: Move visit date helper from hg loader to core (authored by Alphare). · Explain WhyFeb 8 2022, 10:45 AM

This revision was automatically updated to reflect the committed changes.

Alphare added a commit: rDLDBASE98ed83349c08: Move visit date helper from hg loader to core.