Remove most manual Person() parsing in favor of Person.from_fullname
ClosedPublic
Actions

Authored by olasd on Feb 3 2022, 1:31 PM.

Details

Reviewers

Commits

rDLDBASEb3579ed07b63: Remove most manual Person() parsing in favor of Person.from_fullname

Summary

This increases overall consistency and makes us compatible with the
latest version of swh.storage, which does Person.from_fullname() parsing
on output if name and email are None.

Test Plan

tests updated

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Feb 3 2022, 1:31 PM

Build is green

Patch application report for D7072 (id=25660)

Rebasing onto 87de0140c1...

Current branch diff-target is up to date.

Changes applied before test

commit b3579ed07b634ca361ffe9a61f1835ecac41dd9b
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Feb 3 13:30:18 2022 +0100

    Remove most manual Person() parsing in favor of Person.from_fullname
    
    This increases overall consistency and makes us compatible with the
    latest version of swh.storage, which does Person.from_fullname() parsing
    on output if name and email are None.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/689/ for more details.

Harbormaster completed remote builds in B26491: Diff 25660.Feb 3 2022, 1:33 PM

olasd requested review of this revision.Feb 3 2022, 1:33 PM

vlorentz accepted this revision.Feb 3 2022, 1:36 PM

This revision is now accepted and ready to land.Feb 3 2022, 1:36 PM

Closed by commit rDLDBASEb3579ed07b63: Remove most manual Person() parsing in favor of Person.from_fullname (authored by olasd). · Explain WhyFeb 3 2022, 2:14 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLDBASEb3579ed07b63: Remove most manual Person() parsing in favor of Person.from_fullname.