Page MenuHomeSoftware Heritage

Update the debian local package building section
ClosedPublic

Authored by douardda on Jan 26 2022, 12:23 PM.

Details

Summary

to use aptitude as dep resolver and add backports in given cli examples

Diff Detail

Repository
rDDOC Development documentation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thanks.

--build-dep-resolver=aptitude should only be used when building with an extra-repository which has a non-default priority, that is only when using a -backports suite (so only for the bullseye and buster instructions). It should probably be documented in the list of "useful options" rather than as the default.

You could add a list of useful third party repositories pulled from https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/templates/debian/gbp-buildpackage.groovy.j2$122-150

Build is green

Patch application report for D7039 (id=25525)

Rebasing onto 4ac8648fb0...

Current branch diff-target is up to date.
Changes applied before test
commit f25b638039774b9b0cbfc71f9027534be8cca4a9
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jan 26 12:21:01 2022 +0100

    Update the debian local package building section
    
    to use aptitude as dep resolver and add backports in given cli examples

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/108/ for more details.

In D7039#183023, @olasd wrote:

Thanks.

--build-dep-resolver=aptitude should only be used when building with an extra-repository which has a non-default priority, that is only when using a -backports suite (so only for the bullseye and buster instructions). It should probably be documented in the list of "useful options" rather than as the default.

But does it hurt to use it by default?

You could add a list of useful third party repositories pulled from https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/templates/debian/gbp-buildpackage.groovy.j2$122-150

good thinking

In D7039#183023, @olasd wrote:

Thanks.

--build-dep-resolver=aptitude should only be used when building with an extra-repository which has a non-default priority, that is only when using a -backports suite (so only for the bullseye and buster instructions). It should probably be documented in the list of "useful options" rather than as the default.

But does it hurt to use it by default?

It can have a different behavior than the actual resolver used for package builds (e.g. not using the first alternative, or handling transitive dependencies differently), so, yes, it'd be much better to only use it when needed.

You could add a list of useful third party repositories pulled from https://forge.softwareheritage.org/source/swh-jenkins-jobs/browse/master/jobs/templates/debian/gbp-buildpackage.groovy.j2$122-150

good thinking

Ping, what do we do with this diff?

@olasd your last reply is a bit mangled (or is too much quoted?) by the way so i'm not sure i completely get it.

The problem with this last improvement is documenting the correct value to use for the `--extra-repository-key` for each of them...

Ping, what do we do with this diff?

an update is (at last) coming!

@olasd your last reply is a bit mangled (or is too much quoted?) by the way so i'm not sure i completely get it.

specify aptitude is to be used only when needed (sic)

Build has FAILED

Patch application report for D7039 (id=27234)

Rebasing onto 86017fed30...

Current branch diff-target is up to date.
Changes applied before test
commit fcf66939e24bedd97f9741a24201a5b39cb5852f
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jan 26 12:21:01 2022 +0100

    Update the debian local package building section
    
    to use aptitude as dep resolver when needed and add backports in given cli examples

Link to build: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/152/
See console output for more information: https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/152/console

Build is green

Patch application report for D7039 (id=27234)

Rebasing onto 3ee3d1569d...

First, rewinding head to replay your work on top of it...
Applying: Update the debian local package building section
Changes applied before test
commit 1552dabcd9abf91212ae395b39d85ce24c56e6ca
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Jan 26 12:21:01 2022 +0100

    Update the debian local package building section
    
    to use aptitude as dep resolver when needed and add backports in given cli examples

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/153/ for more details.

This revision is now accepted and ready to land.Apr 6 2022, 2:21 PM
This revision was landed with ongoing or failed builds.Apr 6 2022, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7039 (id=27251)

Rebasing onto 9453394818...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-154-D7039.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DDOC/job/build-on-diff/154/ for more details.