utils: Handle new edge cases in parse_external_definition
ClosedPublic
Actions

Authored by anlambert on Jan 21 2022, 3:38 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3870: Analyze svn externals repository ingestion with loader.svn v1.0

Commits

rDLDSVNe6e733005d12: utils: Handle new edge cases in parse_external_definition

Summary

Detect malformed URLs with missing colon.

Remove any trailing slash on path as it can lead to errors with the
swh.model.from_disk.Directory model.

Related to T3870

Fixes SWH-LOADER-SVN-50 and SWH-LOADER-SVN-58.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 21 2022, 3:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 21 2022, 3:38 PM

Build is green

Patch application report for D7013 (id=25424)

Rebasing onto 11740ebc29...

Current branch diff-target is up to date.

Changes applied before test

commit ae79611ae18f910714ae7fb586ed1b9340f8672a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jan 21 15:32:51 2022 +0100

    utils: Handle new edge cases in parse_external_definition
    
    Detect malformed URLs with missing colon.
    
    Remove any trailing slash on path as it can lead to errors with the
    swh.model.from_disk.Directory model.
    
    Related to T3870

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/262/ for more details.

Harbormaster completed remote builds in B26267: Diff 25424.Jan 21 2022, 3:40 PM

anlambert requested review of this revision.Jan 21 2022, 3:40 PM

anlambert mentioned this in T3870: Analyze svn externals repository ingestion with loader.svn v1.0.Jan 21 2022, 3:40 PM

vlorentz accepted this revision.Jan 21 2022, 4:05 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/loader/svn/utils.py
256	should be equivalent

This revision is now accepted and ready to land.Jan 21 2022, 4:05 PM

Simplify regexp.

Build is green

Patch application report for D7013 (id=25429)

Rebasing onto 11740ebc29...

Current branch diff-target is up to date.

Changes applied before test

commit e6e733005d126296f6ce51e4f08a19ff729b5d01
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jan 21 15:32:51 2022 +0100

    utils: Handle new edge cases in parse_external_definition
    
    Detect malformed URLs with missing colon.
    
    Remove any trailing slash on path as it can lead to errors with the
    swh.model.from_disk.Directory model.
    
    Related to T3870

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/263/ for more details.

Harbormaster completed remote builds in B26270: Diff 25429.Jan 21 2022, 4:14 PM

Closed by commit rDLDSVNe6e733005d12: utils: Handle new edge cases in parse_external_definition (authored by anlambert). · Explain WhyJan 21 2022, 4:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVNe6e733005d12: utils: Handle new edge cases in parse_external_definition.