The next release of swh-model will remove it from the constructor, attributes, and dict.
However, this keeps using 'offset' despite the removable from swh-model, because it
needs to be JSON-serializable.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3752: Store/represent time offsets as strings
- Commits
- rDDEPbcb97eb7be27: Remove 'negative_utc'.
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25984 Build 40611: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 40610: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6929 (id=25111)
Rebasing onto 5e98c39f98...
Current branch diff-target is up to date.
Changes applied before test
commit bcb97eb7be273296ded6231593333c91e1ab1139 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Jan 12 18:09:36 2022 +0100 Remove 'negative_utc'. The next release of swh-model will remove it from the constructor, attributes, and dict. However, this keeps using 'offset' despite the removable from swh-model, because it needs to be JSON-serializable.
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/688/ for more details.