Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDMODdbf185c3b36c: Fix TimestampWithTimezone.from_dict() on datetimes before 1970 with non-integer…
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25964 Build 40578: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 40577: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6924 (id=25090)
Rebasing onto 94b00d6877...
Current branch diff-target is up to date.
Changes applied before test
commit ff6594b59db208b5112e8a5de8fd62433466f16c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Jan 12 14:27:15 2022 +0100 Fix TimestampWithTimezone.from_dict() on datetimes before 1970 with non-integer seconds in TZ offsets `int()` rounds negative numbers up.
See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/442/ for more details.
Comment Actions
Build is green
Patch application report for D6924 (id=25093)
Rebasing onto 94b00d6877...
Current branch diff-target is up to date.
Changes applied before test
commit ccf2c5dfcbc9a1444e144d60601c4d384080e8aa Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Jan 12 14:27:15 2022 +0100 Fix TimestampWithTimezone.from_dict() on datetimes before 1970 with non-integer seconds
See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/443/ for more details.
Comment Actions
Build is green
Patch application report for D6924 (id=25094)
Rebasing onto 94b00d6877...
Current branch diff-target is up to date.
Changes applied before test
commit dbf185c3b36c4d79d4214bbf29425c58ba4aa6ba Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Wed Jan 12 14:27:15 2022 +0100 Fix TimestampWithTimezone.from_dict() on datetimes before 1970 with non-integer seconds
See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/444/ for more details.
Comment Actions
Thanks!
swh/model/model.py | ||
---|---|---|
489–491 | Maybe that'd be worth a (separate) warning if the remainder is non-zero... |
swh/model/model.py | ||
---|---|---|
489–491 | indeed, I'll add it later |