browse/utils: Ensure to guess language from filename and not its path
ClosedPublic
Actions

Authored by anlambert on Jan 10 2022, 6:30 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDWAPPS4f7f6281ef8f: browse/utils: Ensure to guess language from filename and not its path

Summary

A filename must be provided as parameter to the get_hljs_language_from_filename
function and not a path.

This fixes some code highlighting issue when a filename who has a language
associated is not in the root directory of the browsed filesystem.

See for instance that CMakeLists.txt file that should have been highlighted as cmake.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 10 2022, 6:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 10 2022, 6:30 PM

Build is green

Patch application report for D6904 (id=25036)

Rebasing onto 835a860126...

Current branch diff-target is up to date.

Changes applied before test

commit 4f7f6281ef8f79e6270226b6b1ea11605d651885
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Jan 10 18:23:19 2022 +0100

    browse/utils: Ensure to guess language from filename and not its path
    
    A filename must be provided as parameter to the get_hljs_language_from_filename
    function and not a path.
    
    This fixes some code highlighting issue when a filename who has a language
    associated is not in the root directory of the browsed filesystem.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1283/ for more details.

Harbormaster completed remote builds in B25904: Diff 25036.Jan 10 2022, 6:45 PM

anlambert requested review of this revision.Jan 10 2022, 6:45 PM

olasd accepted this revision.Jan 11 2022, 10:08 AM

This revision is now accepted and ready to land.Jan 11 2022, 10:08 AM

Closed by commit rDWAPPS4f7f6281ef8f: browse/utils: Ensure to guess language from filename and not its path (authored by anlambert). · Explain WhyJan 11 2022, 11:13 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4f7f6281ef8f: browse/utils: Ensure to guess language from filename and not its path.