Use the in-mem storage instead of mocks to test the journal.
ClosedPublic
Actions

Authored by vlorentz on Nov 20 2018, 4:55 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1307: Remove mock storages used in tests.

Commits

rDJNL468a3ef96dde: Use the in-mem storage instead of mocks to test the journal.

Summary

The build will fail because it depends on an unreleased version of swh.storage.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 20 2018, 4:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2018, 4:55 PM

vlorentz added a task: T1307: Remove mock storages used in tests..Nov 20 2018, 4:57 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/12/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/12/console

Harbormaster failed remote builds in B2482: Diff 2149!Nov 20 2018, 4:57 PM

ardumont accepted this revision.Nov 20 2018, 5:06 PM

This revision is now accepted and ready to land.Nov 20 2018, 5:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/13/ for more details.

Harbormaster completed remote builds in B2482: Diff 2149.Nov 21 2018, 10:16 AM

Restarted the build.

Closed by commit rDJNL468a3ef96dde: Use the in-mem storage instead of mocks to test the journal. (authored by vlorentz). · Explain WhyNov 21 2018, 3:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

test_publisher.py

101 lines

Diff 2155

View Options

swh/journal/tests/test_publisher.py

Use the in-mem storage instead of mocks to test the journal.ClosedPublicActions