Page MenuHomeSoftware Heritage

api/server: Do not prevent noop objstorage to be used as rpc server
ClosedPublic

Authored by ardumont on Dec 8 2021, 9:01 AM.

Details

Summary

The all point of this noop is to be used within development environment. This check
prevented it.

Related to D6759 and the discussion within

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Branch
drop-noop-check
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25464
Build 39804: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 39803: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6780 (id=24604)

Rebasing onto b7adf3823c...

Current branch diff-target is up to date.
Changes applied before test
commit ef0c2f4d100fd70bd3158a08cd5e8ad0e508b53b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 8 08:59:42 2021 +0100

    api/server: Do not prevent noop objstorage to be used as rpc server
    
    The all point of this noop is to be used within development environment. This check
    prevented it.
    
    Related to D6759 and the discussion within

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/73/ for more details.

olasd added a subscriber: olasd.
olasd added inline comments.
swh/objstorage/tests/test_server.py
118–124

Should this just be moved to the previous test?

This revision is now accepted and ready to land.Dec 8 2021, 10:36 AM
swh/objstorage/tests/test_server.py
118–124

good idea.

Amend according to suggestion

swh/objstorage/tests/test_server.py
118–124

done!
less code, miam!

This revision was landed with ongoing or failed builds.Dec 8 2021, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D6780 (id=24607)

Rebasing onto b7adf3823c...

Current branch diff-target is up to date.
Changes applied before test
commit 8f992e8a20e10ed76eab3c7fedee1b93eacc2c4b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 8 08:59:42 2021 +0100

    api/server: Do not prevent noop objstorage to be used as rpc server
    
    The all point of this noop is to be used within development environment. This check
    prevented it.
    
    Related to D6759 and the discussion within

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/74/ for more details.