Differential D6711

browse: Fix issues when context is a release targeting a directory
ClosedPublic
Actions

Authored by anlambert on Dec 1 2021, 2:37 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS5d3515436646: browse: Fix issues when context is a release targeting a directory

Summary

When browsing contents or directories in the context of a release
targeting a directory, there will be no revision identifier involved
in the snapshot context.

This was causing HTTP errors 500 when a staff user was logged in
and an empty revision tab was displayed in the Permalinks dialog
for all users.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 1 2021, 2:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 1 2021, 2:37 PM

Build is green

Patch application report for D6711 (id=24385)

Rebasing onto 3ff49a05ce...

Current branch diff-target is up to date.

Changes applied before test

commit 5d3515436646356ea91df5e3af085c1c25516640
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Dec 1 14:31:42 2021 +0100

    browse: Fix issues when context is a release targeting a directory
    
    When browsing contents or directories in the context of a release
    targeting a directory, there will be no revision identifier involved
    in the snapshot context.
    
    This was causing HTTP errors 500 when a staff user was logged in
    and an empty revision tab was displayed in the Permalinks dialog
    for all users.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1252/ for more details.

Harbormaster completed remote builds in B25262: Diff 24385.Dec 1 2021, 2:56 PM

anlambert requested review of this revision.Dec 1 2021, 2:56 PM

ardumont accepted this revision.Dec 1 2021, 3:55 PM

This revision is now accepted and ready to land.Dec 1 2021, 3:55 PM

Closed by commit rDWAPPS5d3515436646: browse: Fix issues when context is a release targeting a directory (authored by anlambert). · Explain WhyDec 1 2021, 4:02 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS5d3515436646: browse: Fix issues when context is a release targeting a directory.