Page MenuHomeSoftware Heritage

Make MockStorage1 return the same types as the real storage.
ClosedPublic

Authored by vlorentz on Nov 16 2018, 12:24 PM.

Diff Detail

Repository
rDLDG Git loader
Branch
mockstorage-types
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2419
Build 2963: tox-on-jenkinsJenkins
Build 2962: arc lint + arc unit

Event Timeline

ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/loader/git/tests/test_loader.py
244

why did it work before?

This revision is now accepted and ready to land.Nov 16 2018, 12:30 PM
vlorentz added inline comments.
swh/loader/git/tests/test_loader.py
244

Probably because it compared hex representations of "new" stuff with bytes representations of what was already in the db, which were unequal.

This revision was automatically updated to reflect the committed changes.
swh/loader/git/tests/test_loader.py
244

That makes sense.