Differential D664

Make MockStorage1 return the same types as the real storage.
ClosedPublic
Actions

Authored by vlorentz on Nov 16 2018, 12:24 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDG2a3e57db3762: Make MockStorage1 return the same types as the real storage.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 16 2018, 12:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 16 2018, 12:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/23/ for more details.

Harbormaster completed remote builds in B2419: Diff 2091.Nov 16 2018, 12:26 PM

vlorentz added a child revision: D665: Run git loader tests on BulkUpdater too..Nov 16 2018, 12:26 PM

ardumont accepted this revision.Nov 16 2018, 12:30 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/loader/git/tests/test_loader.py
244	why did it work before?

This revision is now accepted and ready to land.Nov 16 2018, 12:30 PM

vlorentz marked an inline comment as done.Nov 16 2018, 1:12 PM

vlorentz added inline comments.

swh/loader/git/tests/test_loader.py
244	Probably because it compared hex representations of "new" stuff with bytes representations of what was already in the db, which were unequal.

Closed by commit rDLDG2a3e57db3762: Make MockStorage1 return the same types as the real storage. (authored by vlorentz). · Explain WhyNov 16 2018, 1:13 PM

This revision was automatically updated to reflect the committed changes.

ardumont added inline comments.Nov 16 2018, 1:24 PM

swh/loader/git/tests/test_loader.py
244	That makes sense.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

tests/

test_loader.py

32 lines

Diff 2093

View Options

swh/loader/git/tests/test_loader.py

Make MockStorage1 return the same types as the real storage.ClosedPublicActions