Differential D6644

Fix flakyness in test_client_with_deserializer
ClosedPublic
Actions

Authored by douardda on Nov 16 2021, 2:03 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDJNL808a4efcbd9a: Fix flakyness in test_client_with_deserializer

Summary

since there is no guarantee the "expected" (considered invalid) revision will
be consumed first, the outcome of this test was flaky. So use the client
with 'stop_on_eof' instead of 'stop_after_objects'.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Nov 16 2021, 2:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 16 2021, 2:03 PM

douardda added a child revision: D6645: Replace usage of 'stop_after_objects' by 'stop_on_eof' in tests.Nov 16 2021, 2:03 PM

Build is green

Patch application report for D6644 (id=24146)

Rebasing onto 79d28b51ae...

Current branch diff-target is up to date.

Changes applied before test

commit 808a4efcbd9af7517e67fee08c66c06bf274de05
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Nov 16 13:58:09 2021 +0100

    Fix flakyness in test_client_with_deserializer
    
    since there is no guarantee the "expected" (considered invalid) revision will
    be consumed first, the outcome of this test was flaky. So use the client
    with 'stop_on_eof' instead of 'stop_after_objects'.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/180/ for more details.

Harbormaster completed remote builds in B25026: Diff 24146.Nov 16 2021, 2:06 PM

douardda requested review of this revision.Nov 16 2021, 2:06 PM

since there is no guarantee the "expected" (considered invalid) revision will be consumed first

Really? Shouldn't the order be guaranteed by having only one partition per topic?

vlorentz accepted this revision.Nov 16 2021, 2:44 PM

This revision is now accepted and ready to land.Nov 16 2021, 2:44 PM

In D6644#172803, @vlorentz wrote:

since there is no guarantee the "expected" (considered invalid) revision will be consumed first

Really? Shouldn't the order be guaranteed by having only one partition per topic?

the fact is the test was flaky... dunno if this is is caused by some mocking somewhere or so, but...

Closed by commit rDJNL808a4efcbd9a: Fix flakyness in test_client_with_deserializer (authored by douardda). · Explain WhyNov 16 2021, 4:28 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNL808a4efcbd9a: Fix flakyness in test_client_with_deserializer.