since there is no guarantee the "expected" (considered invalid) revision will
be consumed first, the outcome of this test was flaky. So use the client
with 'stop_on_eof' instead of 'stop_after_objects'.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDJNL808a4efcbd9a: Fix flakyness in test_client_with_deserializer
Diff Detail
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Branch
- master
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 25026 Build 39108: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 39107: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6644 (id=24146)
Rebasing onto 79d28b51ae...
Current branch diff-target is up to date.
Changes applied before test
commit 808a4efcbd9af7517e67fee08c66c06bf274de05
Author: David Douard <david.douard@sdfa3.org>
Date: Tue Nov 16 13:58:09 2021 +0100
Fix flakyness in test_client_with_deserializer
since there is no guarantee the "expected" (considered invalid) revision will
be consumed first, the outcome of this test was flaky. So use the client
with 'stop_on_eof' instead of 'stop_after_objects'.See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/180/ for more details.
Comment Actions
since there is no guarantee the "expected" (considered invalid) revision will be consumed first
Really? Shouldn't the order be guaranteed by having only one partition per topic?
Comment Actions
the fact is the test was flaky... dunno if this is is caused by some mocking somewhere or so, but...