Differential D6598

Add type annotations
ClosedPublic
Actions

Authored by vlorentz on Nov 3 2021, 2:32 PM.

Details

Reviewers

stsp

Commits

rDLDCVSbab0a5c61fc2: Add type annotations

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

typing

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24853
Build 38817: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 38816: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 3 2021, 2:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 3 2021, 2:32 PM

vlorentz edited reviewers, added: stsp; removed: Reviewers.Nov 3 2021, 2:33 PM

Build has FAILED

Patch application report for D6598 (id=23976)

Rebasing onto 7cffdf709f...

Current branch diff-target is up to date.

Changes applied before test

commit 117521abc707f1f67051e9343f9d1d7a59dd0b57
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 14:32:35 2021 +0100

    Add type annotations

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/48/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/48/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 3 2021, 2:33 PM

Harbormaster failed remote builds in B24852: Diff 23976!

vlorentz mentioned this in D6593: handle Attic-only RCS files over CVS pserver.Nov 3 2021, 2:49 PM

fix lint

Build has FAILED

Patch application report for D6598 (id=23977)

Rebasing onto 7cffdf709f...

Current branch diff-target is up to date.

Changes applied before test

commit d044215fc79862c84427bf0154f3708b30f4ee1c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 14:32:35 2021 +0100

    Add type annotations

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/49/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/49/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 3 2021, 2:50 PM

Harbormaster failed remote builds in B24853: Diff 23977!

fix lint

Build is green

Patch application report for D6598 (id=23979)

Rebasing onto 7cffdf709f...

Current branch diff-target is up to date.

Changes applied before test

commit bab0a5c61fc24a5f2dd11377f42581af8d7aeb7a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 14:32:35 2021 +0100

    Add type annotations

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/50/ for more details.

Harbormaster completed remote builds in B24854: Diff 23979.Nov 3 2021, 3:00 PM

vlorentz requested review of this revision.Nov 3 2021, 3:00 PM

stsp accepted this revision.Nov 5 2021, 1:26 PM

This revision is now accepted and ready to land.Nov 5 2021, 1:26 PM

stsp added inline comments.Nov 5 2021, 1:29 PM