Page MenuHomeSoftware Heritage

Add type annotations
ClosedPublic

Authored by vlorentz on Wed, Nov 3, 2:32 PM.

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6598 (id=23976)

Rebasing onto 7cffdf709f...

Current branch diff-target is up to date.
Changes applied before test
commit 117521abc707f1f67051e9343f9d1d7a59dd0b57
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 14:32:35 2021 +0100

    Add type annotations

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/48/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/48/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 3, 2:33 PM
Harbormaster failed remote builds in B24852: Diff 23976!

Build has FAILED

Patch application report for D6598 (id=23977)

Rebasing onto 7cffdf709f...

Current branch diff-target is up to date.
Changes applied before test
commit d044215fc79862c84427bf0154f3708b30f4ee1c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 14:32:35 2021 +0100

    Add type annotations

Link to build: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/49/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/49/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 3, 2:50 PM
Harbormaster failed remote builds in B24853: Diff 23977!

Build is green

Patch application report for D6598 (id=23979)

Rebasing onto 7cffdf709f...

Current branch diff-target is up to date.
Changes applied before test
commit bab0a5c61fc24a5f2dd11377f42581af8d7aeb7a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Nov 3 14:32:35 2021 +0100

    Add type annotations

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/50/ for more details.

This revision is now accepted and ready to land.Fri, Nov 5, 1:26 PM
swh/loader/cvs/loader.py
55

Does this class serve some purpose or could it be removed?

This revision was automatically updated to reflect the committed changes.
swh/loader/cvs/loader.py
55

Oops, I used it to debug and forgot to remove it