bin/update: Run 'pre-commit install' to setup the git hook.
AbandonedPublic
Actions

Authored by vlorentz on Oct 28 2021, 2:52 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Diff Detail

Repository

rDENV Development environment

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 24793
Build 38712: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 28 2021, 2:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 28 2021, 2:52 PM

vlorentz requested review of this revision.Oct 28 2021, 2:52 PM

Harbormaster completed remote builds in B24793: Diff 23915.Oct 28 2021, 2:52 PM

ok but won't that slow things down even more?

can't we also use the -j 4 stanza ?

That's supposed to already be handled by the fixup hook for each repo in .mrconfig, isn't it?

ah, right. it didn't run for me because I had unstaged changes

That's supposed to already be handled by the fixup hook for each repo in .mrconfig, isn't it?

I'm not sure that's run each time though, is it?
At initial time yes, but afterwards...

In D6579#170972, @ardumont wrote:

That's supposed to already be handled by the fixup hook for each repo in .mrconfig, isn't it?

I'm not sure that's run each time though, is it?
At initial time yes, but afterwards...

from man mr:

fixups
    If "fixups" is set, its command is run whenever a repository is checked out, or updated. This provides an easy way to do things like permissions fixups, or other tweaks to the repository content, whenever the repository is changed.

Oh, I get it. the fixups we have are:

grep -q pre-commit.com .git/hooks/pre-commit || pre-commit install

but I already had pre-commit installed in .git/hooks/pre-commit so it didn't run.

The reason I wanted to re-install it is to update the shebang

Revision Contents
Changeset List

Path

Size

bin/

update

2 lines

Diff 23915

View Options

bin/update: Run 'pre-commit install' to setup the git hook.AbandonedPublicActions