Page MenuHomeSoftware Heritage

cran: Fix ListedOrigin visit type
ClosedPublic

Authored by anlambert on Oct 22 2021, 2:44 PM.

Details

Summary

CRAN origins must be loaded with the cran visit type and not the tar one.

This is the reason why the CRAN origins are marked as not visited in scheduler metrics.

It also means that CRAN origins currently do not get loaded in production as there is
no scheduler task type named load-tar.

Related to T3675

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24659
Build 38483: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 38482: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6539 (id=23774)

Rebasing onto 5bba1a783a...

Current branch diff-target is up to date.
Changes applied before test
commit 20232cc36ea79b9195055ee68a6d0ff789a4d0de
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 22 14:36:02 2021 +0200

    cran: Fix ListedOrigin visit type
    
    CRAN origins must be loaded with the cran visit type and not the tar one.
    
    Related to T3675

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/400/ for more details.

ardumont added a subscriber: ardumont.

Thanks.

That makes sense for almost everything.

I don't get how they end up having a snapshot...
Maybe the runs happen prior to the lister refactoring.

This revision is now accepted and ready to land.Oct 22 2021, 2:48 PM
This revision was automatically updated to reflect the committed changes.