Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T3685: Our pip usage is broken since a recent pip release
- Commits
- rDENVe899f36ffb20: Dockerfile: Avoid pip 21.3 version preventing working container override
without fix, override container swh-scheduler-runner:
doco up -d doco logs -f swh-scheduler-runner # fails to start with paste error
With the fix, the container starts.
Diff Detail
- Repository
- rDENV Development environment
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
Patch application report for D6537 (id=23764)
Rebasing onto ecc0e2803e...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-476-D6537.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/476/ for more details.
This is the same diff as D6536 no ?
i updated the diff from the wrong local repository.
If you refresh it, that'd be the right diff now.
| docker/utils/pyutils.sh | ||
|---|---|---|
| 14 ↗ | (On Diff #23765) | I already tested that pip option and it will fail to install swh-search as tree_sitter uses PEP-517 in its setup.py. The only solution is to force installation of pip != 21.3 in Dockerfile. |
| docker/utils/pyutils.sh | ||
|---|---|---|
| 14 ↗ | (On Diff #23765) | Right, your remark reminds me that you already told me that... i had forgotten. So the solution is within the dockerfile. I did try an early fix on the Dockerfile which worked. Dropping the --upgrade pip in |
| docker/utils/pyutils.sh | ||
|---|---|---|
| 14 ↗ | (On Diff #23765) | I would rather blacklist the 21.3 release when upgrading: pip install --upgrade 'pip!=21.3'. |
| docker/utils/pyutils.sh | ||
|---|---|---|
| 14 ↗ | (On Diff #23765) | ack, i'll try that one. |
| docker/utils/pyutils.sh | ||
|---|---|---|
| 14 ↗ | (On Diff #23765) | Thanks, that works. A small warning explained it did as we asked, great. WARNING: You are using pip version 21.2.4; however, version 21.3 is available. You should consider upgrading via the '/srv/softwareheritage/venv/bin/python3 -m pip install --upgrade pip' command. |