Page MenuHomeSoftware Heritage

cassandra: Fix incomplete check of content existence in object_find_by_sha1_git
ClosedPublic

Authored by vlorentz on Oct 18 2021, 1:00 PM.

Details

Summary

content_missing_by_sha1_git only checks the index and not the main table.

This is incorrect, because contents should not be considered written
before an entry is written to the main table, even if an entry
exists in one of the indexes.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6494 (id=23597)

Rebasing onto e9fd74d72d...

Current branch diff-target is up to date.
Changes applied before test
commit a9867104771069c0f5f964a1995a2f2ddf47da93
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 18 13:00:00 2021 +0200

    cassandra: Fix incomplete check of content existence in object_find_by_sha1_git
    
    content_missing_by_sha1_git only checks the index and not the main table.
    
    This is incorrect, because contents should not be considered written
    before an entry is written to the main table, even if an entry
    exists in one of the indexes.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1455/ for more details.

Build was aborted

Patch application report for D6494 (id=23596)

Rebasing onto e9fd74d72d...

Current branch diff-target is up to date.
Changes applied before test
commit 5cd44a37b516b9f898118c533ec4ede13ebfc418
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 18 13:00:00 2021 +0200

    cassandra: Fix incomplete check of content existence in object_find_by_sha1_git
    
    content_missing_by_sha1_git only checks the index and not the main table.
    
    This is incorrect, because contents should not be considered written
    before an entry is written to the main table, even if an entry
    exists in one of the indexes.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1454/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1454/console

This revision is now accepted and ready to land.Oct 19 2021, 11:38 AM