Page MenuHomeSoftware Heritage

origin_save: Lift save request creation restrictions with permission
ClosedPublic

Authored by anlambert on Wed, Oct 6, 5:23 PM.

Details

Summary

Following our meeting about SWH integration with JOSS (Journal of Open Science Software),
add a new permission to lift save code now creation restrictions.

Users with the swh.web.api.save_origin permission:

  • will not be rate limited on the /api/1/origin/save/ endpoint
  • will have their save requests immediately accepted

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6425 (id=23346)

Rebasing onto cc60a4a5c8...

Current branch diff-target is up to date.
Changes applied before test
commit 0da4e46ae3c158ba103bcb3d2b2322686a7e3233
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Oct 6 16:57:16 2021 +0200

    origin_save: Lift save request creation restrictions with permission
    
    Users with the "swh.web.api.save_origin" permission:
    
      - will not be rate limited on the /api/1/origin/save/ endpoint
    
      - will have their save requests immediately accepted

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1144/ for more details.

lgtm

jsyk, that's the kind of slight adaptations will want to add in the webapp so we can let
yannick access the deposit moderation view at some point. Create a new role, assign that
role to specific users (in keycloak) and slightly adapt the webapp code to check the
logged in user has the proper role to let them access. (I don't recall the task id if
there is one ;)

This revision is now accepted and ready to land.Wed, Oct 6, 6:04 PM