Rename imports of swh.model.identifiers to fix deprecation warnings.
ClosedPublic
Actions

Authored by vlorentz on Oct 6 2021, 2:17 PM.

Details

Reviewers

ardumont
olasd

Group Reviewers

Reviewers

Commits

rDVAU6fd1f523e394: Rename imports of swh.model.identifiers to fix deprecation warnings.

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 6 2021, 2:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2021, 2:17 PM

Build is green

Patch application report for D6420 (id=23337)

Rebasing onto 8588d3e8f6...

Current branch diff-target is up to date.

Changes applied before test

commit 6fd1f523e394b5e59ce43199b9787096abcf335c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Oct 6 14:16:43 2021 +0200

    Rename imports of swh.model.identifiers to fix deprecation warnings.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/183/ for more details.

Harbormaster completed remote builds in B24250: Diff 23337.Oct 6 2021, 2:18 PM

vlorentz requested review of this revision.Oct 6 2021, 2:18 PM

ardumont accepted this revision.Oct 6 2021, 4:44 PM

This revision is now accepted and ready to land.Oct 6 2021, 4:44 PM

Looks fine (i.e. the identifiers DeprecationWarnings are gone in tox, except for one that gets triggered by some pytest internal assertion rewrite).

In my tox run there seems to be a bunch of warnings about identifiers being computed from dicts, but I've not looked at /where/ they were really happening.

Closed by commit rDVAU6fd1f523e394: Rename imports of swh.model.identifiers to fix deprecation warnings. (authored by vlorentz). · Explain WhyOct 7 2021, 10:29 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU6fd1f523e394: Rename imports of swh.model.identifiers to fix deprecation warnings..