Page MenuHomeSoftware Heritage

git: Add debugging log around the packfile retrieval step
ClosedPublic

Authored by ardumont on Oct 1 2021, 12:16 PM.

Details

Summary

This helps troubleshooting stuff in docker

Test Plan

tox

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24144
Build 37679: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 37678: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6385 (id=23225)

Could not rebase; Attempt merge onto 940a5e7e6f...

Updating 940a5e7..289f000
Fast-forward
 swh/loader/git/loader.py | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)
Changes applied before test
commit 289f0007c7507209bfa069521b5cb1b151fd5f3e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 1 09:15:59 2021 +0200

    git: Add debugging log around the packfile retrieval step

commit c7160263202f1a2669931c2e138448e9e1e34438
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 30 20:10:05 2021 +0200

    Unify log instruction to use the module logger instance
    
    This unifies logging instructions as other swh package does it.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/127/ for more details.

Build is green

Patch application report for D6385 (id=23227)

Could not rebase; Attempt merge onto 940a5e7e6f...

Updating 940a5e7..c2f8af0
Fast-forward
 swh/loader/git/converters.py |  6 +++---
 swh/loader/git/from_disk.py  | 22 ++++++++++++----------
 swh/loader/git/loader.py     | 29 ++++++++++++++++++++++-------
 3 files changed, 37 insertions(+), 20 deletions(-)
Changes applied before test
commit c2f8af0c8bb3a513057af45ab3ec60bbdfa1a86a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 1 09:15:59 2021 +0200

    git: Add debugging log around the packfile retrieval step

commit a34aefbf0a7d0647ffcee5fcf99a307bdf1e0298
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 30 20:10:05 2021 +0200

    Unify logging instructions to use module logger instance
    
    This unifies logging instructions with swh packages.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/129/ for more details.

anlambert added inline comments.
swh/loader/git/loader.py
219–221

I would rather put that debug log before line 295

296

To remove if you apply my previous inline comment.

Adapt according to sound suggestion

ardumont added inline comments.
swh/loader/git/loader.py
219–221

right, adapted, thanks.

Build is green

Patch application report for D6385 (id=23228)

Could not rebase; Attempt merge onto 940a5e7e6f...

Updating 940a5e7..1d69d2b
Fast-forward
 swh/loader/git/converters.py |  6 +++---
 swh/loader/git/from_disk.py  | 22 ++++++++++++----------
 swh/loader/git/loader.py     | 29 +++++++++++++++++++++--------
 3 files changed, 36 insertions(+), 21 deletions(-)
Changes applied before test
commit 1d69d2be3b3b0eaf14e046dad1a343da9d9cba1a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 1 09:15:59 2021 +0200

    git: Add debugging log around the packfile retrieval step

commit a34aefbf0a7d0647ffcee5fcf99a307bdf1e0298
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 30 20:10:05 2021 +0200

    Unify logging instructions to use module logger instance
    
    This unifies logging instructions with swh packages.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/130/ for more details.

This revision is now accepted and ready to land.Oct 1 2021, 1:13 PM