Differential D643

Fix storage doc.
ClosedPublic
Actions

Authored by vlorentz on Nov 9 2018, 12:08 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTOC14e17d1c48e2: Fix storage doc.
R65:14e17d1c48e2: Fix storage doc.
rDSTO14e17d1c48e2: Fix storage doc.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 9 2018, 12:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 9 2018, 12:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/50/ for more details.

Harbormaster completed remote builds in B2291: Diff 1991.Nov 9 2018, 12:16 PM

vlorentz mentioned this in D635: [WIP] In-memory storage implementation.Nov 9 2018, 1:01 PM

olasd accepted this revision.Nov 9 2018, 2:05 PM

olasd added a subscriber: olasd.

olasd added inline comments.

swh/storage/storage.py
957	Even if none is allowed, that's still an int?

This revision is now accepted and ready to land.Nov 9 2018, 2:05 PM

Closed by commit rDSTO14e17d1c48e2: Fix storage doc. (authored by vlorentz). · Explain WhyNov 9 2018, 6:38 PM

This revision was automatically updated to reflect the committed changes.

vlorentz marked an inline comment as done.Nov 9 2018, 6:42 PM

vlorentz added inline comments.

swh/storage/storage.py
957	I believe identifiers should be opaque. in fact, in the in-mem storage, it's not an int.

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

50 lines

Diff 2011

View Options

Fix storage doc.ClosedPublicActions