Differential D6343

misc/coverage: Add heptapod to listed origins
ClosedPublic
Actions

Authored by anlambert on Sep 24 2021, 4:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS14a3caeadc8c: misc/coverage: Add heptapod to listed origins

Summary

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 24 2021, 4:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2021, 4:26 PM

anlambert edited the summary of this revision. (Show Details)Sep 24 2021, 4:28 PM

Build is green

Patch application report for D6343 (id=23061)

Rebasing onto dd6dde3e44...

Current branch diff-target is up to date.

Changes applied before test

commit 14a3caeadc8ceb7059db4b46cc7ec95726f75fa4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 24 16:22:08 2021 +0200

    misc/coverage: Add heptapod to listed origins

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1123/ for more details.

Harbormaster completed remote builds in B23988: Diff 23061.Sep 24 2021, 4:43 PM

anlambert requested review of this revision.Sep 24 2021, 4:43 PM

lgtm

@douardda here we go ^ (3 new instances in the screenshot, including the logilab one and heptapod)

By the way, this morning, we discussed with david and zack that it'd be great if that would be made dynamic.
No idea how to fetch the correct logo though.

This revision is now accepted and ready to land.Sep 24 2021, 5:03 PM

By the way, this morning, we discussed with david and zack that it'd be great if that would be made dynamic.
No idea how to fetch the correct logo though.

The best option would be to store the origin types in a database table.
The png logo could be stored as a base64 string in a dedicated column.
We could even add an admin interface in swh-web to easily edit that list of origin types.

Closed by commit rDWAPPS14a3caeadc8c: misc/coverage: Add heptapod to listed origins (authored by anlambert). · Explain WhySep 28 2021, 11:16 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS14a3caeadc8c: misc/coverage: Add heptapod to listed origins.