I want to use parametrized tests in a future commit, but pytest does not
support them on unittest-style classes.
self.subTest() would work too, but I figured it's a good time to migrate
these tests to be consistent with the rest of the codebase.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDG85eb54015c6b: Migrate to pytest-style tests
Diff Detail
Diff Detail
- Repository
- rDLDG Git loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D6279 (id=22740)
Rebasing onto 8ad9799f28...
Current branch diff-target is up to date.
Changes applied before test
commit 85eb54015c6ba2faba8e438a54a76fdc1aeb8e06 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Thu Sep 16 11:49:26 2021 +0200 Migrate to pytest-style tests I want to use parametrized tests in a future commit, but pytest does not support them on unittest-style classes. self.subTest() would work too, but I figured it's a good time to migrate these tests to be consistent with the rest of the codebase.
See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/104/ for more details.
swh/loader/git/tests/test_converters.py | ||
---|---|---|
118 | I don't think this mark is useful anymore (it used to mark tests that would depend on resources external to the current package) |