Page MenuHomeSoftware Heritage

wip: Allow download to follow redirection to fetch more tarballs
AbandonedPublic

Authored by ardumont on Mon, Sep 13, 6:18 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T3468: staging: current opam loading issues
Summary

Related to T3468

Diff Detail

Event Timeline

Build is green

Patch application report for D6250 (id=22629)

Rebasing onto 0efaf7a0ef...

Current branch diff-target is up to date.
Changes applied before test
commit 29bdee5082806e2cf41ecb1acabba9e8418b3396
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 13 18:16:57 2021 +0200

    Allow download to follow redirection to fetch more tarballs
    
    Related to T3468

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/544/ for more details.

requests.get already follows redirects by default. I believe that this boolean only applies to POST/PUT/DELETE requests.

In D6250#161647, @olasd wrote:

requests.get already follows redirects by default. I believe that this boolean only applies to POST/PUT/DELETE requests.

https://docs.python-requests.org/en/latest/api/

allow_redirects (bool) – (optional) Boolean. Enable/disable GET/OPTIONS/POST/PUT/PATCH/DELETE/HEAD redirection. Defaults to True.