It's brittle, and not the right place.
Depends on D6113.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS8d735fb8de9f: Remove page refresh hack from updateVaultItemList.
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- vault
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23126 Build 36070: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 36069: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6129 (id=22169)
Could not rebase; Attempt merge onto 8acd726369...
Merge made by the 'recursive' strategy.
assets/src/bundles/vault/vault-create-tasks.js | 50 ++--
assets/src/bundles/vault/vault-table-row.ejs | 18 +-
assets/src/bundles/vault/vault-ui.js | 66 ++++--
...d19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} | Bin
...a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} | Bin
cypress/integration/vault.spec.js | 153 ++++++++----
swh/web/api/views/vault.py | 257 ++++++++++++++-------
swh/web/browse/snapshot_context.py | 4 +-
swh/web/browse/urls.py | 6 +-
swh/web/browse/views/directory.py | 4 +-
swh/web/browse/views/release.py | 8 +-
swh/web/browse/views/revision.py | 6 +-
swh/web/common/archive.py | 25 +-
swh/web/templates/includes/vault-create-tasks.html | 22 +-
swh/web/tests/api/views/test_vault.py | 230 +++++++++++++++---
15 files changed, 590 insertions(+), 259 deletions(-)
rename cypress/fixtures/{cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz => swh:1:dir:cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} (100%)
rename cypress/fixtures/{1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz => swh:1:rev:1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} (100%)Changes applied before test
commit ea40c0ed4c8d0ebe85e54bf3c35d50e999f0d9f8
Merge: 8acd7263 291ffa1e
Author: Jenkins user <jenkins@localhost>
Date: Tue Aug 24 14:18:14 2021 +0000
Merge branch 'diff-target' into HEAD
commit 291ffa1ef2d1a1e5e230e992b8b6e44011b3b286
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Aug 24 16:17:28 2021 +0200
Remove page refresh hack from updateVaultItemList.
It's brittle, and not the right place.
commit b217cb75e4466f64c6f9809d9c4eaabb858fd627
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Aug 18 19:02:10 2021 +0200
vault API: Rename bundle types and use SWHIDs to identify objects
This is to match changes in the vault interface, see D6112 for the rationale.
All existing queries still work, through "fallback" views. There are
some minor changes in returned fields (removed obj_type, and replace
obj_id with swhid), but I don't think anyone used them (since that info
is already available to them before they send the request).
commit e6463f5241a3da404ea5f60dd52807054f060449
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Aug 24 11:23:53 2021 +0200
vault.spec.js: Add test checking the LocalStorage is used to show the task list
commit c8a1808415d796500ea16774db024a92dc050593
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Aug 24 10:19:22 2021 +0200
vault.spec.js: Remove vaultItems from global variables
So tests don't have side-effectsSee https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1021/ for more details.
Comment Actions
Build is green
Patch application report for D6129 (id=22180)
Could not rebase; Attempt merge onto 773d6c2e06...
Updating 773d6c2e..8d735fb8
Fast-forward
assets/src/bundles/vault/vault-create-tasks.js | 50 ++--
assets/src/bundles/vault/vault-table-row.ejs | 18 +-
assets/src/bundles/vault/vault-ui.js | 65 +++--
...d19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} | Bin
...a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} | Bin
cypress/integration/vault.spec.js | 114 +++++----
swh/web/api/views/vault.py | 267 ++++++++++++++-------
swh/web/browse/snapshot_context.py | 4 +-
swh/web/browse/urls.py | 6 +-
swh/web/browse/views/directory.py | 4 +-
swh/web/browse/views/release.py | 8 +-
swh/web/browse/views/revision.py | 6 +-
swh/web/common/archive.py | 25 +-
swh/web/templates/includes/vault-create-tasks.html | 22 +-
swh/web/tests/api/views/test_vault.py | 230 +++++++++++++++---
15 files changed, 556 insertions(+), 263 deletions(-)
rename cypress/fixtures/{cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz => swh:1:dir:cd19126d815470b28919d64b2a8e6a3e37f900dd.tar.gz} (100%)
rename cypress/fixtures/{1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz => swh:1:rev:1c480a4573d2a003fc2630c21c2b25829de49972.gitfast.gz} (100%)Changes applied before test
commit 8d735fb8de9f96c9245e3da636f4485e2108dacf
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Aug 24 16:17:28 2021 +0200
Remove page refresh hack from updateVaultItemList.
It's brittle, and not the right place.
commit c402ae6a4ca6355519903c5c61f11fa4f81ccb7a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Wed Aug 18 19:02:10 2021 +0200
vault API: Rename bundle types and use SWHIDs to identify objects
This is to match changes in the vault interface, see D6112 for the rationale.
All existing queries still work, through "fallback" views. There are
some minor changes in returned fields (removed obj_type, and replace
obj_id with swhid), but I don't think anyone used them (since that info
is already available to them before they send the request).See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1027/ for more details.