So far, it was only updated on checker failure.
However, many failures may happen while loading, and we had no
way to report them to users so far (besides diving ourselves
in the logs/Sentry)
Written with @ardumont
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3467: Make deposit loader explicit the status_detail when the ingestion fails
- Commits
- rDLDBASE63a8a61cbc98: deposit: Update status_detail on loader failure
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22975 Build 35819: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 35818: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 81 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.archive.tests.test_archive::test_archive_2_visits_with_new_artifact swh_storage = <swh.storage.proxies.retry.RetryingProxyStorage object at 0x7ffaa85ef9e8>
requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7ffaa841e780>
| |
| 89 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.archive.tests.test_archive::test_archive_2_visits_without_change swh_storage = <swh.storage.proxies.retry.RetryingProxyStorage object at 0x7ffaa85442b0>
requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7ffaa83a49b0>
| |
| 76 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.archive.tests.test_archive::test_archive_2_visits_without_change_not_gnu swh_storage = <swh.storage.proxies.retry.RetryingProxyStorage object at 0x7ffaa8a46630>
requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7ffaa843c208>
| |
| 79 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.archive.tests.test_archive::test_archive_not_gzipped_tarball swh_storage = <swh.storage.proxies.retry.RetryingProxyStorage object at 0x7ffaa83eee48>
requests_mock = <requests_mock.mocker.Mocker object at 0x7ffaa7b74128>
not_gzipped_tarball_bytes = b'8sync-0.1.0/\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00...00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
| |
| 87 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.package.archive.tests.test_archive::test_archive_snapshot_append swh_storage = <swh.storage.proxies.retry.RetryingProxyStorage object at 0x7ffaa841e710>
requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7ffaa83ee240>
| |
| View Full Test Results (46 Failed · 105 Passed) |
Event Timeline
Comment Actions
Build is green
Patch application report for D6079 (id=22013)
Rebasing onto 6118d43e6f...
Current branch diff-target is up to date.
Changes applied before test
commit 462a195ca294c45a0b7fe95b4b3e9901229215bc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 12 11:06:51 2021 +0200
deposit: Update status_detail on loader failure
So far, it was only updated on checker failure.
However, many failures may happen while loading, and we had no
way to report them to users so far (besides diving ourselves
in the logs/Sentry)See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/505/ for more details.
Comment Actions
Looks good to me.
This also requires some update on the deposit side.
It's ongoing work.
Comment Actions
Build has FAILED
Patch application report for D6079 (id=22016)
Rebasing onto 6118d43e6f...
Current branch diff-target is up to date.
Changes applied before test
commit 53087b5b53fa59708937bb5344ea2006dab3e10f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 12 11:06:51 2021 +0200
deposit: Update status_detail on loader failure
So far, it was only updated on checker failure.
However, many failures may happen while loading, and we had no
way to report them to users so far (besides diving ourselves
in the logs/Sentry)Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/506/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/506/console
Comment Actions
Build is green
Patch application report for D6079 (id=22015)
Rebasing onto 573df1cc3d...
Current branch diff-target is up to date.
Changes applied before test
commit 737838e772c8b1aa3e8766b2927d0391337695a9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 12 11:27:51 2021 +0200
deposit_update_status: Add support for updating status_detail
This will be used by the deposit loader in case of failure,
to tell users what the actual error is.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/673/ for more details.
Comment Actions
Build is green
Patch application report for D6079 (id=22018)
Rebasing onto 6118d43e6f...
Current branch diff-target is up to date.
Changes applied before test
commit 63a8a61cbc9837db5851c267a02838f886384a24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Aug 12 11:06:51 2021 +0200
deposit: Update status_detail on loader failure
So far, it was only updated on checker failure.
However, many failures may happen while loading, and we had no
way to report them to users so far (besides diving ourselves
in the logs/Sentry)See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/507/ for more details.