Differential D6069

from_disk: Do not drop tags with missing tagger or date
ClosedPublic
Actions

Authored by vlorentz on Aug 6 2021, 7:46 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDLDG5448b7b1615d: from_disk: Do not drop tags with missing tagger or date

Summary

Old versions of Git didn't writer them, eg. see tags refs/tags/v2.6.11
to refs/tags/v2.6.13-rc3 in linux.git

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 6 2021, 7:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2021, 7:46 PM

Build is green

Patch application report for D6069 (id=21978)

Rebasing onto 92ef526eb6...

Current branch diff-target is up to date.

Changes applied before test

commit 5448b7b1615d0eb9593d9adc0393bef51a42ef16
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 6 19:46:18 2021 +0200

    from_disk: Do not drop tags with missing tagger or date
    
    Old versions of Git didn't writer them, eg. see tags refs/tags/v2.6.11
    to refs/tags/v2.6.13-rc3 in linux.git

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/103/ for more details.

Harbormaster completed remote builds in B22939: Diff 21978.Aug 6 2021, 7:48 PM

vlorentz requested review of this revision.Aug 6 2021, 7:48 PM

douardda accepted this revision.Aug 9 2021, 11:32 AM

This revision is now accepted and ready to land.Aug 9 2021, 11:32 AM

Closed by commit rDLDG5448b7b1615d: from_disk: Do not drop tags with missing tagger or date (authored by vlorentz). · Explain WhyAug 9 2021, 12:30 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDG5448b7b1615d: from_disk: Do not drop tags with missing tagger or date.

is there some plan to reunify the loader and from_disk implementation?

Beware the spurious prints in the implementation.

No idea, I don't know why it's designed that way.