Page MenuHomeSoftware Heritage

celery: configure result_serializer to msgpack
ClosedPublic

Authored by douardda on Oct 25 2018, 3:12 PM.

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Sounds better to be explicit about this.
Currently, it seems we use pickle [1] according to the current doc [2] [3]

Not sure what this implies for production though.
@olasd any thoughts?

Note:

  • when we'll switch to 4.0, the default serializer will switch from pickle to json [2]
  • when we finally migrate to superior version, we could also change those default using the new naming convention (that's out of scope here, just mentioning it for later)

[1] I remember something about moving away from pickle but the details escape me... (it might have been only for the task serializer though...).

[2] http://docs.celeryproject.org/en/latest/userguide/configuration.html#result-serializer

[3] we are running on debian stable so version is 3.1.23

This revision is now accepted and ready to land.Oct 25 2018, 3:45 PM
This revision was automatically updated to reflect the committed changes.