Differential D5989

pattern: Use URL network location as instance name when not provided
ClosedPublic
Actions

Authored by anlambert on Jul 13 2021, 12:40 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3403: Use forge URL network location as default lister instance name

Commits

rDLS6c123508634c: pattern: Use URL network location as instance name when not provided

Summary

Make the instance parameter of the base pattern lister optional and set
lister name to URL network location when not provided.

It simplifies lister creation when associated forge type have a lot of
instances in the wild (e.g. gitlab or cgit) while giving more details
about the listed forge instance.

Also process listers for forge with multiple instances (cgit, gitea,
gitlab, phabricator and tuleap) to ensure URL network location will be
used when instance parameter is not provided.

Related to T3403

Diff Detail

Repository

rDLS Listers

Branch

lister-instance-netloc-default

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 22590
Build 35205: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 35204: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 13 2021, 12:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 13 2021, 12:40 PM

Build is green

Patch application report for D5989 (id=21615)

Rebasing onto df46b22098...

Current branch diff-target is up to date.

Changes applied before test

commit 6c123508634c6467b2fb9be83de69e6a5e77363a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 13 12:33:41 2021 +0200

    pattern: Use URL network location as instance name when not provided
    
    Make the instance parameter of the base pattern lister optional and set
    lister name to URL network location when not provided.
    
    It simplifies lister creation when associated forge type have a lot of
    instances in the wild (e.g. gitlab or cgit) while giving more details
    about the listed forge instance.
    
    Also process listers for forge with multiple instances (cgit, gitea,
    gitlab, phabricator and tuleap) to ensure URL network location will be
    used when instance parameter is not provided.
    
    Related to T3403

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/331/ for more details.

Harbormaster completed remote builds in B22590: Diff 21615.Jul 13 2021, 12:43 PM

anlambert requested review of this revision.Jul 13 2021, 12:43 PM