The default ONE level is used to keep the previous behaviour
Related to T3396
Details
Details
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D5974 (id=21523)
Rebasing onto f1cac4fcaa...
Current branch diff-target is up to date.
Changes applied before test
commit 232e76b45788106d6e03d2d0f990347c8f1560a2
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Tue Jul 6 16:54:57 2021 +0200
cassandra: Allow to configure the consistency level to use
The default ONE level is used to keep the previous behaviour
Related to 3396Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1349/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1349/console
Comment Actions
Build has FAILED
Patch application report for D5974 (id=21524)
Rebasing onto f1cac4fcaa...
Current branch diff-target is up to date.
Changes applied before test
commit 22a41b088405b611719a6623ed98e8ecf3769b64
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Tue Jul 6 16:54:57 2021 +0200
cassandra: Allow to configure the consistency level to use
The default ONE level is used to keep the previous behaviour
Related to T3396Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1350/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1350/console
Comment Actions
Build is green
Patch application report for D5974 (id=21525)
Rebasing onto f1cac4fcaa...
Current branch diff-target is up to date.
Changes applied before test
commit 936001b343d68057069199da2ef06b609b59adc0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Tue Jul 6 16:54:57 2021 +0200
cassandra: Allow to configure the consistency level to use
The default ONE level is used to keep the previous behaviour
Related to T3396See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1351/ for more details.
Comment Actions
lgtm, one question and suggestions inline.
| swh/storage/cassandra/cql.py | ||
|---|---|---|
| 84 | that's not a logging instruction so you can use f-string here ;) | |
| 106 | Shouldn't this be consistent with the execution profile the CqlRunner uses? No idea... After checking which part is using this, it seems to be mostly a test utility function so i'm confused... @vlorentz any hints? | |
| swh/storage/tests/test_cassandra.py | ||
| 251 | Not to check the full log of the exception but to check the at the very least, it raises for the right reason. | |
| swh/storage/cassandra/cql.py | ||
|---|---|---|
| 106 | IMO it's not necessary at it's only to bootstrap the database. | |
| swh/storage/cassandra/cql.py | ||
|---|---|---|
| 106 | my previous comment was the reply to
| |
| swh/storage/cassandra/cql.py | ||
|---|---|---|
| 106 | yes, thanks, i understood it that way ;) | |
Comment Actions
Build is green
Patch application report for D5974 (id=21532)
Rebasing onto f1cac4fcaa...
Current branch diff-target is up to date.
Changes applied before test
commit 9747aed6cbf1b31b87a8c3d00fe0177da357d056
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Tue Jul 6 16:54:57 2021 +0200
cassandra: Allow to configure the consistency level to use
The default ONE level is used to keep the previous behaviour
Related to T3396See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1352/ for more details.