Page MenuHomeSoftware Heritage

hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'.
ClosedPublic

Authored by vlorentz on Jun 25 2021, 5:24 PM.

Details

Summary

We agreed a while ago they should be IRIs and not just URIs.

This will trigger crashes in swh.storage.cassandra, as
currently expects (wrongly) that origin urls are ASCII.

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22274
Build 34667: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 34666: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5931 (id=21294)

Rebasing onto 4009b3a3cf...

Current branch diff-target is up to date.
Changes applied before test
commit cfb3073c27e00d9cf9302897afce7c2555afc5fd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 17:24:40 2021 +0200

    hypothesis_strategies: generate non-ASCII IRIs for origin and authority 'urls'.
    
    We agreed a while ago they should be IRIs and not just URIs.
    
    This will trigger crashes in swh.storage.cassandra, as
    currently expects (wrongly) that origin urls are ASCII.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/361/ for more details.

This revision is now accepted and ready to land.Jun 28 2021, 1:56 PM