Page MenuHomeSoftware Heritage

hypothesis_strategies: Restrict size and alphabets for metadata_fetchers and raw_extrinsic_metadata
ClosedPublic

Authored by vlorentz on Jun 25 2021, 5:08 PM.

Details

Summary
  • empty fetcher name or version is not accepted by cassandra (and is nonsensical anyway)
  • ditto for non-ASCII (and any non-printable is nonsensical)
  • null bytes/chars are accepted by neither postgresql or cassandra

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5930 (id=21291)

Rebasing onto 90b477e521...

Current branch diff-target is up to date.
Changes applied before test
commit 4009b3a3cf6a9142d391f793af247fa4794566e6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Jun 25 17:08:01 2021 +0200

    hypothesis_strategies: Restrict size and alphabets for metadata_fetchers and raw_extrinsic_metadata
    
    * empty fetcher name or version is not accepted by cassandra
      (and is nonsensical anyway)
    * ditto for non-ASCII (and any non-printable is nonsensical)
    * null bytes/chars are accepted by neither postgresql or cassandra

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/360/ for more details.

This revision is now accepted and ready to land.Jun 25 2021, 5:14 PM