Update methods associated to the origin-revision layer
Also fix outdated comments and code styling.
Depends on D5863
Differential D5880
Update methods associated to the origin-revision layer aeviso on Jun 16 2021, 1:56 PM. Authored by
Details Update methods associated to the origin-revision layer Also fix outdated comments and code styling. Depends on D5863
Diff Detail
Event TimelineComment Actions Build is green Patch application report for D5880 (id=21066)Could not rebase; Attempt merge onto c9d1369ba1... Updating c9d1369..3161678 Fast-forward swh/provenance/archive.py | 21 ++--- swh/provenance/model.py | 73 ++++++++++----- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 35 ++----- swh/provenance/postgresql/provenancedb_base.py | 102 +++++++++++++-------- .../postgresql/provenancedb_with_path.py | 26 +++--- .../postgresql/provenancedb_without_path.py | 22 +++-- swh/provenance/provenance.py | 42 +++++---- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 42 +++------ 10 files changed, 205 insertions(+), 171 deletions(-) Changes applied before testcommit 316167843f015e10ec876a47bde84e03bbbdfbbd Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update methods associated to the origin-revision layer commit 6accfd7e4e38fae66317859e59f2876f586e16a7 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit 6c148a713f2d29d97095fdf75fa379c02847c0c0 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit 8aa8e5ed543e1ca20f867f0f7886e7e30502d5e8 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 13:59:30 2021 +0200 Rework ArchiveInterface Unused methods were removed and type annotations fixed. See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/143/ for more details. Comment Actions Build is green Patch application report for D5880 (id=21087)Could not rebase; Attempt merge onto c9d1369ba1... Updating c9d1369..af163b0 Fast-forward swh/provenance/archive.py | 42 +++++--- swh/provenance/model.py | 111 ++++++++++----------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 67 +++++++------ swh/provenance/postgresql/provenancedb_base.py | 102 ++++++++++++------- .../postgresql/provenancedb_with_path.py | 26 ++--- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 42 +++++--- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 +++++++------ 10 files changed, 286 insertions(+), 211 deletions(-) Changes applied before testcommit af163b0c683efb263e6225e8951cff356da593a2 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit 9d5c0ceba2908ca8cf8243517b3cc8569117af50 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit 9d081d6acee99f93ddc40a55f87839c32580ba6c Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit f309f67a524cc29d12ae4cfb65c482f5aa6aaac9 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Unused methods were removed and type annotations fixed. Other methos in OriginEntry and RevisionEntry were updated accordingly commit 12edf4a3b7992575f5f24cd8a648c803dbda142a Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieven parents in RevisionEntry See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/147/ for more details. Comment Actions Build is green Patch application report for D5880 (id=21091)Could not rebase; Attempt merge onto c9d1369ba1... Updating c9d1369..a8c2c44 Fast-forward swh/provenance/archive.py | 42 +++++--- swh/provenance/model.py | 111 ++++++++++----------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 67 +++++++------ swh/provenance/postgresql/provenancedb_base.py | 102 ++++++++++++------- .../postgresql/provenancedb_with_path.py | 26 ++--- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 42 +++++--- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 +++++++------ 10 files changed, 286 insertions(+), 211 deletions(-) Changes applied before testcommit a8c2c44810277dba0532c5cd3dabc0f14d82bc45 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit cf9136d10a143c962b5b37baad9321d7ff4959d1 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit efb4c361330a1402ec25ecb0b62b8ab41382c740 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit a12961f7536eb2e25c81b4f106c028dc6c655b29 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Unused methods were removed and type annotations fixed. Other methos in OriginEntry and RevisionEntry were updated accordingly commit 12edf4a3b7992575f5f24cd8a648c803dbda142a Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieven parents in RevisionEntry See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/151/ for more details. Comment Actions Build is green Patch application report for D5880 (id=21092)Could not rebase; Attempt merge onto c9d1369ba1... Updating c9d1369..4c20456 Fast-forward swh/provenance/archive.py | 42 +++++--- swh/provenance/model.py | 111 ++++++++++----------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 67 +++++++------ swh/provenance/postgresql/provenancedb_base.py | 102 ++++++++++++------- .../postgresql/provenancedb_with_path.py | 26 ++--- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 48 +++++---- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 +++++++------ 10 files changed, 289 insertions(+), 214 deletions(-) Changes applied before testcommit 4c204561c0d3264e81b3fb1b75cf80e44ccbd9be Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit cf9136d10a143c962b5b37baad9321d7ff4959d1 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit efb4c361330a1402ec25ecb0b62b8ab41382c740 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit a12961f7536eb2e25c81b4f106c028dc6c655b29 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Unused methods were removed and type annotations fixed. Other methos in OriginEntry and RevisionEntry were updated accordingly commit 12edf4a3b7992575f5f24cd8a648c803dbda142a Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieven parents in RevisionEntry See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/152/ for more details. Comment Actions Mostly nitpicking comments, but I'd really prefer that:
Comment Actions Build is green Patch application report for D5880 (id=21133)Could not rebase; Attempt merge onto 8ff1ab5860... Updating 8ff1ab5..e89b9a7 Fast-forward requirements-swh.txt | 2 +- swh/provenance/archive.py | 42 +++++-- swh/provenance/model.py | 90 +++++++------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 67 ++++++----- swh/provenance/postgresql/provenancedb_base.py | 133 +++++++++++++-------- .../postgresql/provenancedb_with_path.py | 26 ++-- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 48 +++++--- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 ++++++----- 11 files changed, 295 insertions(+), 220 deletions(-) Changes applied before testcommit e89b9a7ccfccd526c09f66c292664a7b5c7e4aa9 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit ce6a2a4dedc80f6a19918b6b927b4d35462fc484 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit a7e977c8af91a7b7a40655a30fe19211b6d794da Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit 969e3359123b781ae1101e2fb62b9934b0988478 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Remove Unused methods and fix type annotations. Update Other methods in OriginEntry and RevisionEntry accordingly. commit d28d3eed7049e36c5841405021fd0a0e78c11cb7 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieving parents in RevisionEntry Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`. Create a list with the iterator returned by `ArchiveInterface.revision_get ()` before comparison. See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/164/ for more details.
Comment Actions Build is green Patch application report for D5880 (id=21141)Could not rebase; Attempt merge onto 8ff1ab5860... Updating 8ff1ab5..ef13a5a Fast-forward requirements-swh.txt | 2 +- swh/provenance/archive.py | 42 +++++-- swh/provenance/model.py | 90 +++++++------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 70 ++++++----- swh/provenance/postgresql/provenancedb_base.py | 133 +++++++++++++-------- .../postgresql/provenancedb_with_path.py | 26 ++-- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 48 +++++--- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 ++++++----- 11 files changed, 298 insertions(+), 220 deletions(-) Changes applied before testcommit ef13a5a5072cd3f0a68367571613ba45ff8e3c84 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit 4953a1688a19b956a33164b4e5540edb3b8e2c78 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit e610883f5d89c58e409cc7ddf490a4a778b99dcd Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit 01bbb0ce850a5cfafaa1837fa346a19b2a851fc9 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Remove Unused methods and fix type annotations. Update Other methods in OriginEntry and RevisionEntry accordingly. commit cd48f9d71efeaf73cfcc24f397d22589a5f7987b Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieving parents in RevisionEntry Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`. Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison. See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/169/ for more details.
Comment Actions Build is green Patch application report for D5880 (id=21154)Could not rebase; Attempt merge onto 8ff1ab5860... Updating 8ff1ab5..31f9aad Fast-forward requirements-swh.txt | 2 +- swh/provenance/archive.py | 42 +++++-- swh/provenance/model.py | 90 +++++++------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 70 ++++++----- swh/provenance/postgresql/provenancedb_base.py | 133 +++++++++++++-------- .../postgresql/provenancedb_with_path.py | 26 ++-- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 63 ++++++---- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 ++++++----- 11 files changed, 308 insertions(+), 225 deletions(-) Changes applied before testcommit 31f9aad728a70b7bfe9f065b86bf78ab1126bc99 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit 4953a1688a19b956a33164b4e5540edb3b8e2c78 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit e610883f5d89c58e409cc7ddf490a4a778b99dcd Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit 01bbb0ce850a5cfafaa1837fa346a19b2a851fc9 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Remove Unused methods and fix type annotations. Update Other methods in OriginEntry and RevisionEntry accordingly. commit cd48f9d71efeaf73cfcc24f397d22589a5f7987b Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieving parents in RevisionEntry Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`. Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison. See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/171/ for more details. Comment Actions Thanks for the DatetimeCache & co. I'm fine with this, but note the last comments I've added, I'd prefer these to be addressed here, but no big deal if not.
Comment Actions Build is green Patch application report for D5880 (id=21173)Could not rebase; Attempt merge onto 011645221c... Updating 0116452..f2ec1e5 Fast-forward requirements-swh.txt | 2 +- swh/provenance/archive.py | 42 +++++-- swh/provenance/model.py | 90 +++++++------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 70 ++++++----- swh/provenance/postgresql/provenancedb_base.py | 133 +++++++++++++-------- .../postgresql/provenancedb_with_path.py | 26 ++-- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 62 ++++++---- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 ++++++----- 11 files changed, 307 insertions(+), 225 deletions(-) Changes applied before testcommit f2ec1e58c91f1fda1121c6d7c1e29dede6431d45 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit fd66d83c119d8f8b283098f6320bf6f68cc7114f Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit 417fd014d96f09b8a20831a6a060cfb408376d5c Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit f354b65e52ed78b3a637b2632e1b74bb920669be Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Remove Unused methods and fix type annotations. Update Other methods in OriginEntry and RevisionEntry accordingly. commit e6f39d0244b10b49942b0ab93d4628828e343642 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieving parents in RevisionEntry Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`. Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison. See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/179/ for more details. Comment Actions Build is green Patch application report for D5880 (id=21184)Could not rebase; Attempt merge onto 011645221c... Updating 0116452..a0e6dff Fast-forward requirements-swh.txt | 2 +- swh/provenance/archive.py | 42 +++++-- swh/provenance/model.py | 90 +++++++------- swh/provenance/origin.py | 3 +- swh/provenance/postgresql/archive.py | 70 ++++++----- swh/provenance/postgresql/provenancedb_base.py | 133 +++++++++++++-------- .../postgresql/provenancedb_with_path.py | 26 ++-- .../postgresql/provenancedb_without_path.py | 22 ++-- swh/provenance/provenance.py | 62 ++++++---- swh/provenance/sql/30-schema.sql | 10 +- swh/provenance/storage/archive.py | 72 ++++++----- 11 files changed, 307 insertions(+), 225 deletions(-) Changes applied before testcommit a0e6dffc572d46a8b0b4407319eeb5b189cf9dc8 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 13:53:25 2021 +0200 Update backend methods associated to the origin-revision layer commit fd66d83c119d8f8b283098f6320bf6f68cc7114f Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Wed Jun 16 11:11:23 2021 +0200 Fix outdated comments and code styling. commit 417fd014d96f09b8a20831a6a060cfb408376d5c Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Mon Jun 14 14:03:09 2021 +0200 Refactor RevisionEntry's parents iterator Make parents a class property and create a separate method to retrieve information from the archive, just as it is done for the other model classes commit f354b65e52ed78b3a637b2632e1b74bb920669be Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:51:54 2021 +0200 Rework ArchiveInterface Remove Unused methods and fix type annotations. Update Other methods in OriginEntry and RevisionEntry accordingly. commit e6f39d0244b10b49942b0ab93d4628828e343642 Author: Andres Ezequiel Viso <aeviso@softwareheritage.org> Date: Thu Jun 17 13:48:24 2021 +0200 Fix bugs when retrieving parents in RevisionEntry Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`. Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison. See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/184/ for more details. |