Page MenuHomeSoftware Heritage
Differential D5863

Refactor RevisionEntry's parents iterator
ClosedPublic
Actions

Authored by aeviso on Jun 14 2021, 2:09 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDPROV417fd014d96f: Refactor RevisionEntry's parents iterator
Summary

Make parents a class property and create a separate method to retrieve information
from the archive, just as it is done for the other model classes

Depends on D5862

Diff Detail

Repository
rDPROV Provenance database
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aeviso created this revision.Jun 14 2021, 2:09 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 14 2021, 2:09 PM
swh-public-ci added a comment.Jun 14 2021, 2:12 PM

Build is green

Patch application report for D5863 (id=20987)

Could not rebase; Attempt merge onto 206399eb8a...

Updating 206399e..6374a65
Fast-forward
 swh/provenance/archive.py            | 21 ++++-------
 swh/provenance/model.py              | 73 ++++++++++++++++++++++++------------
 swh/provenance/origin.py             |  3 +-
 swh/provenance/postgresql/archive.py | 35 +++++------------
 swh/provenance/storage/archive.py    | 42 +++++++--------------
 5 files changed, 82 insertions(+), 92 deletions(-)
Changes applied before test
commit 6374a653a43e183aad7d152ecb6255caea1c4278
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit a30a6794422d281f91b656f38b45368ec9d4e47c
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 13:59:30 2021 +0200

    Rework ArchiveInterface
    
    Unused methods were removed and type annotations fixed.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/131/ for more details.

Harbormaster completed remote builds in B21967: Diff 20987.Jun 14 2021, 2:12 PM
aeviso requested review of this revision.Jun 14 2021, 2:12 PM
douardda accepted this revision.Jun 14 2021, 2:49 PM
douardda added a subscriber: douardda.

please take care of not including unrelated changes in your revisions/diffs

swh/provenance/model.py
37

not a blocker here, but this should not be in this revision either; it's unrelated with the refactoring of the RevisionEntry class.

This revision is now accepted and ready to land.Jun 14 2021, 2:49 PM
aeviso updated this revision to Diff 21061.Jun 16 2021, 10:40 AM

Rebase

swh-public-ci added a comment.Jun 16 2021, 10:45 AM

Build is green

Patch application report for D5863 (id=21061)

Could not rebase; Attempt merge onto c9d1369ba1...

Updating c9d1369..6c148a7
Fast-forward
 swh/provenance/archive.py            | 21 ++++-------
 swh/provenance/model.py              | 73 ++++++++++++++++++++++++------------
 swh/provenance/origin.py             |  3 +-
 swh/provenance/postgresql/archive.py | 35 +++++------------
 swh/provenance/storage/archive.py    | 42 +++++++--------------
 5 files changed, 82 insertions(+), 92 deletions(-)
Changes applied before test
commit 6c148a713f2d29d97095fdf75fa379c02847c0c0
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit 8aa8e5ed543e1ca20f867f0f7886e7e30502d5e8
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 13:59:30 2021 +0200

    Rework ArchiveInterface
    
    Unused methods were removed and type annotations fixed.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/142/ for more details.

Harbormaster completed remote builds in B22052: Diff 21061.Jun 16 2021, 10:45 AM
aeviso added a child revision: D5880: Update methods associated to the origin-revision layer.Jun 16 2021, 1:56 PM
aeviso updated this revision to Diff 21086.Jun 17 2021, 2:03 PM

Rebase

swh-public-ci added a comment.Jun 17 2021, 2:09 PM

Build is green

Patch application report for D5863 (id=21086)

Could not rebase; Attempt merge onto c9d1369ba1...

Updating c9d1369..9d081d6
Fast-forward
 swh/provenance/archive.py            |  42 +++++++++----
 swh/provenance/model.py              | 111 +++++++++++++++++------------------
 swh/provenance/origin.py             |   3 +-
 swh/provenance/postgresql/archive.py |  67 +++++++++++----------
 swh/provenance/storage/archive.py    |  72 ++++++++++++-----------
 5 files changed, 163 insertions(+), 132 deletions(-)
Changes applied before test
commit 9d081d6acee99f93ddc40a55f87839c32580ba6c
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit f309f67a524cc29d12ae4cfb65c482f5aa6aaac9
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:51:54 2021 +0200

    Rework ArchiveInterface
    
    Unused methods were removed and type annotations fixed.
    Other methos in OriginEntry and RevisionEntry were updated accordingly

commit 12edf4a3b7992575f5f24cd8a648c803dbda142a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:48:24 2021 +0200

    Fix bugs when retrieven parents in RevisionEntry

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B22074: Diff 21086.Jun 17 2021, 2:09 PM
aeviso updated this revision to Diff 21088.Jun 17 2021, 2:15 PM

Rebase

aeviso updated this revision to Diff 21090.Jun 17 2021, 2:16 PM

Rebase

swh-public-ci added a comment.Jun 17 2021, 2:18 PM

Build is green

Patch application report for D5863 (id=21088)

Could not rebase; Attempt merge onto c9d1369ba1...

Updating c9d1369..a12961f
Fast-forward
 swh/provenance/archive.py            | 42 +++++++++++++++------
 swh/provenance/model.py              | 72 +++++++++++++-----------------------
 swh/provenance/postgresql/archive.py | 67 ++++++++++++++++++---------------
 swh/provenance/storage/archive.py    | 72 +++++++++++++++++++-----------------
 4 files changed, 131 insertions(+), 122 deletions(-)
Changes applied before test
commit a12961f7536eb2e25c81b4f106c028dc6c655b29
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:51:54 2021 +0200

    Rework ArchiveInterface
    
    Unused methods were removed and type annotations fixed.
    Other methos in OriginEntry and RevisionEntry were updated accordingly

commit 12edf4a3b7992575f5f24cd8a648c803dbda142a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:48:24 2021 +0200

    Fix bugs when retrieven parents in RevisionEntry

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/148/ for more details.

Harbormaster completed remote builds in B22076: Diff 21088.Jun 17 2021, 2:18 PM
swh-public-ci added a comment.Jun 17 2021, 2:24 PM

Build is green

Patch application report for D5863 (id=21090)

Could not rebase; Attempt merge onto c9d1369ba1...

Updating c9d1369..efb4c36
Fast-forward
 swh/provenance/archive.py            |  42 +++++++++----
 swh/provenance/model.py              | 111 +++++++++++++++++------------------
 swh/provenance/origin.py             |   3 +-
 swh/provenance/postgresql/archive.py |  67 +++++++++++----------
 swh/provenance/storage/archive.py    |  72 ++++++++++++-----------
 5 files changed, 163 insertions(+), 132 deletions(-)
Changes applied before test
commit efb4c361330a1402ec25ecb0b62b8ab41382c740
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit a12961f7536eb2e25c81b4f106c028dc6c655b29
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:51:54 2021 +0200

    Rework ArchiveInterface
    
    Unused methods were removed and type annotations fixed.
    Other methos in OriginEntry and RevisionEntry were updated accordingly

commit 12edf4a3b7992575f5f24cd8a648c803dbda142a
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:48:24 2021 +0200

    Fix bugs when retrieven parents in RevisionEntry

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/150/ for more details.

Harbormaster completed remote builds in B22078: Diff 21090.Jun 17 2021, 2:24 PM
aeviso updated this revision to Diff 21132.Jun 18 2021, 1:33 PM

rebase

swh-public-ci added a comment.Jun 18 2021, 1:39 PM

Build is green

Patch application report for D5863 (id=21132)

Could not rebase; Attempt merge onto 8ff1ab5860...

Updating 8ff1ab5..a7e977c
Fast-forward
 requirements-swh.txt                 |  2 +-
 swh/provenance/archive.py            | 42 ++++++++++++-----
 swh/provenance/model.py              | 90 ++++++++++++++++--------------------
 swh/provenance/origin.py             |  3 +-
 swh/provenance/postgresql/archive.py | 67 +++++++++++++++------------
 swh/provenance/storage/archive.py    | 72 ++++++++++++++++-------------
 6 files changed, 150 insertions(+), 126 deletions(-)
Changes applied before test
commit a7e977c8af91a7b7a40655a30fe19211b6d794da
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit 969e3359123b781ae1101e2fb62b9934b0988478
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:51:54 2021 +0200

    Rework ArchiveInterface
    
    Remove Unused methods and fix type annotations. Update Other methods in
    OriginEntry and RevisionEntry accordingly.

commit d28d3eed7049e36c5841405021fd0a0e78c11cb7
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:48:24 2021 +0200

    Fix bugs when retrieving parents in RevisionEntry
    
    Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`.
    
    Create a list with the iterator returned by `ArchiveInterface.revision_get ()` before comparison.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/163/ for more details.

Harbormaster completed remote builds in B22118: Diff 21132.Jun 18 2021, 1:39 PM
aeviso updated this revision to Diff 21140.Jun 18 2021, 3:39 PM

rebase

swh-public-ci added a comment.Jun 18 2021, 3:47 PM

Build is green

Patch application report for D5863 (id=21140)

Could not rebase; Attempt merge onto 8ff1ab5860...

Updating 8ff1ab5..e610883
Fast-forward
 requirements-swh.txt                 |  2 +-
 swh/provenance/archive.py            | 42 ++++++++++++-----
 swh/provenance/model.py              | 90 ++++++++++++++++--------------------
 swh/provenance/origin.py             |  3 +-
 swh/provenance/postgresql/archive.py | 70 ++++++++++++++++------------
 swh/provenance/storage/archive.py    | 72 ++++++++++++++++-------------
 6 files changed, 153 insertions(+), 126 deletions(-)
Changes applied before test
commit e610883f5d89c58e409cc7ddf490a4a778b99dcd
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit 01bbb0ce850a5cfafaa1837fa346a19b2a851fc9
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:51:54 2021 +0200

    Rework ArchiveInterface
    
    Remove Unused methods and fix type annotations. Update Other methods in
    OriginEntry and RevisionEntry accordingly.

commit cd48f9d71efeaf73cfcc24f397d22589a5f7987b
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:48:24 2021 +0200

    Fix bugs when retrieving parents in RevisionEntry
    
    Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`.
    Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/168/ for more details.

Harbormaster completed remote builds in B22127: Diff 21140.Jun 18 2021, 3:47 PM
aeviso updated this revision to Diff 21172.Jun 21 2021, 5:12 PM

rebase

swh-public-ci added a comment.Jun 21 2021, 5:19 PM

Build is green

Patch application report for D5863 (id=21172)

Could not rebase; Attempt merge onto 011645221c...

Updating 0116452..417fd01
Fast-forward
 requirements-swh.txt                 |  2 +-
 swh/provenance/archive.py            | 42 ++++++++++++-----
 swh/provenance/model.py              | 90 ++++++++++++++++--------------------
 swh/provenance/origin.py             |  3 +-
 swh/provenance/postgresql/archive.py | 70 ++++++++++++++++------------
 swh/provenance/storage/archive.py    | 72 ++++++++++++++++-------------
 6 files changed, 153 insertions(+), 126 deletions(-)
Changes applied before test
commit 417fd014d96f09b8a20831a6a060cfb408376d5c
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Mon Jun 14 14:03:09 2021 +0200

    Refactor RevisionEntry's parents iterator
    
    Make parents a class property and create a separate method to retrieve information
    from the archive, just as it is done for the other model classes

commit f354b65e52ed78b3a637b2632e1b74bb920669be
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:51:54 2021 +0200

    Rework ArchiveInterface
    
    Remove Unused methods and fix type annotations. Update Other methods in
    OriginEntry and RevisionEntry accordingly.

commit e6f39d0244b10b49942b0ab93d4628828e343642
Author: Andres Ezequiel Viso <aeviso@softwareheritage.org>
Date:   Thu Jun 17 13:48:24 2021 +0200

    Fix bugs when retrieving parents in RevisionEntry
    
    Convert `Revision.date` from` TimestampWithTimezone` to `datetime` as expected by` RevisionEntry`.
    Create a list with the iterator returned by `ArchiveInterface.revision_get()` before comparison.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/178/ for more details.

Harbormaster completed remote builds in B22159: Diff 21172.Jun 21 2021, 5:19 PM
Closed by commit rDPROV417fd014d96f: Refactor RevisionEntry's parents iterator (authored by aeviso). · Explain WhyJun 22 2021, 10:50 AM
This revision was automatically updated to reflect the committed changes.
aeviso added a commit: rDPROV417fd014d96f: Refactor RevisionEntry's parents iterator.

Revision Contents
Changeset List

PathSize
swh/
provenance/
46 lines
3 lines

Diff 21188

View Options

swh/provenance/model.py

Loading...
View Options

swh/provenance/origin.py

Loading...
About · Developer information · Legal