Page MenuHomeSoftware Heritage

Add endpoints to access REMD by id
ClosedPublic

Authored by vlorentz on Jun 14 2021, 5:06 PM.

Details

Summary

This will be used by swh-web to allow downloading them
from a non-JSON endpoint: T2938

Diff Detail

Repository
rDSTO Storage manager
Branch
remd-by-id
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22029
Build 34263: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 34262: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5865 (id=20994)

Rebasing onto 036d227330...

Current branch diff-target is up to date.
Changes applied before test
commit a81b86932434d5b579115f861b84add021caf198
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jun 14 17:06:18 2021 +0200

    Add endpoints to access REMD by id
    
    This will be used by swh-web to allow downloading them
    from a non-JSON endpoint.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1342/ for more details.

ardumont added a subscriber: ardumont.

lgtm, couple of remarks regarding a print statement and a potential missing type inline.

Also, if i understand correctly the pattern, for each new need of reading (here the raw
metadata per id), we need to add new tables in the schema?

swh/storage/cassandra/storage.py
1383

one print to remove, one!

swh/storage/in_memory.py
599

missing type?

This revision is now accepted and ready to land.Jun 15 2021, 10:15 AM

Also, if i understand correctly the pattern, for each new need of reading (here the raw
metadata per id), we need to add new tables in the schema?

yes

This revision was landed with ongoing or failed builds.Jun 15 2021, 3:09 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D5865 (id=21036)

Rebasing onto 47575a6932...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1343-D5865.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1343/ for more details.