This will be used by swh-web to allow downloading them
from a non-JSON endpoint: T2938
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3018: Allow querying raw_extrinsic_metadata by hash in swh-storage
T2938: Create API endpoint to access raw_extrinsic_metadata - Commits
- rDSTO47575a69323e: Add endpoints to access REMD by id
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D5865 (id=20994)
Rebasing onto 036d227330...
Current branch diff-target is up to date.
Changes applied before test
commit a81b86932434d5b579115f861b84add021caf198 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jun 14 17:06:18 2021 +0200 Add endpoints to access REMD by id This will be used by swh-web to allow downloading them from a non-JSON endpoint.
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1342/ for more details.
Comment Actions
lgtm, couple of remarks regarding a print statement and a potential missing type inline.
Also, if i understand correctly the pattern, for each new need of reading (here the raw
metadata per id), we need to add new tables in the schema?
swh/storage/cassandra/storage.py | ||
---|---|---|
1383 | one print to remove, one! | |
swh/storage/in_memory.py | ||
599 | missing type? |
Comment Actions
Build is green
Patch application report for D5865 (id=21036)
Rebasing onto 47575a6932...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-1343-D5865.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1343/ for more details.