Page MenuHomeSoftware Heritage

tests/test_search: Use a reasonably long description value
ClosedPublic

Authored by anlambert on Jun 11 2021, 12:50 PM.

Details

Summary

Previous value was inducing pytest log pollution when tests fail
as the whole JSON query is printed in that case.

This was resulting in a really big and hard to exploit log file.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/128/consoleText as an example of such log file.

Diff Detail

Repository
rDSEA Archive search
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21932
Build 34111: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 34110: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D5855 (id=20953)

Rebasing onto 870aecd97d...

Current branch diff-target is up to date.
Changes applied before test
commit 35142063f335f5141f8d52ac81fda6b2dd3a497e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 11 12:45:25 2021 +0200

    tests/test_search: Use a reasonably long description value
    
    Previous value was inducing pytest log pollution when tests fail
    as the whole JSON query is printed in that case.
    
    This was resulting in a really big and hard to exploit log file.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/130/ for more details.

olasd added a subscriber: olasd.

Thanks!

This revision is now accepted and ready to land.Jun 11 2021, 1:10 PM