cypress: Use webpack-dev-server to serve static assets
ClosedPublic
Actions

Authored by anlambert on May 20 2021, 7:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS79c6da6bed5a: cypress: Use webpack-dev-server to serve static assets

Summary

It enables to not relaunch cypress UI when modifying swh-web
assets sources, static assets will be recompiled on the fly
insead of prior launching cypress.

Cypress tests will also be automatically re-executed when
static assets sources have changed.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 20 2021, 7:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 20 2021, 7:07 PM

Build is green

Patch application report for D5762 (id=20606)

Rebasing onto 33daf4c007...

Current branch diff-target is up to date.

Changes applied before test

commit 3aaac995e73be9625adc7de1699596e884493524
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu May 20 19:03:30 2021 +0200

    cypress: Use webpack-dev-server to serve static assets
    
    It enables to not relaunch cypress UI when modifying swh-web
    assets sources, static assets will be recompiled on the fly
    insead of prior launching cypress.
    
    Cypress tests will also be automatically re-executed when
    static assets sources have changed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/843/ for more details.

Harbormaster completed remote builds in B21571: Diff 20606.May 20 2021, 7:17 PM

anlambert requested review of this revision.May 20 2021, 7:17 PM

Awesome ;)

one remark/question inline .

Makefile.local
104	? Note: on my machine $ echo $$$$ 1461314613 $ echo $$ 14613 ah or is it an escape form in some ways for the Makefile?

This revision is now accepted and ready to land.May 21 2021, 9:24 AM

anlambert added inline comments.May 21 2021, 11:24 AM

Makefile.local
104	yes we need to escape `$` with `$$` in the Makefile.

Reword comment

Build is green

Patch application report for D5762 (id=20612)

Rebasing onto 33daf4c007...

Current branch diff-target is up to date.

Changes applied before test

commit 79c6da6bed5aa697a805d7a0ea168dd8e42a0f26
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu May 20 19:03:30 2021 +0200

    cypress: Use webpack-dev-server to serve static assets
    
    It enables to not relaunch cypress UI when modifying swh-web
    assets sources, static assets will be recompiled on the fly
    insead of prior launching cypress.
    
    Cypress tests will also be automatically re-executed when
    static assets sources have changed.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/844/ for more details.

Harbormaster completed remote builds in B21577: Diff 20612.May 21 2021, 11:35 AM

Closed by commit rDWAPPS79c6da6bed5a: cypress: Use webpack-dev-server to serve static assets (authored by anlambert). · Explain WhyMay 21 2021, 11:38 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS79c6da6bed5a: cypress: Use webpack-dev-server to serve static assets.