Makefile.local: Wrap long lines
ClosedPublic
Actions

Authored by anlambert on May 20 2021, 1:53 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS33daf4c007a2: Makefile.local: Wrap long lines

Summary

Let's make those long commands a little bit more readable.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 20 2021, 1:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 20 2021, 1:53 PM

Build is green

Patch application report for D5760 (id=20592)

Rebasing onto 5adccbb354...

Current branch diff-target is up to date.

Changes applied before test

commit 4488b1d6f4d07acafca86fa0e9aa33366d6b5b0c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu May 20 13:52:56 2021 +0200

    Makefile.local: Wrap long lines

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/835/ for more details.

Harbormaster completed remote builds in B21557: Diff 20592.May 20 2021, 2:03 PM

anlambert requested review of this revision.May 20 2021, 2:03 PM

lgtm

one question inline

Makefile.local
100–102	`\| head -1` got dropped no idea if it's intended.

This revision is now accepted and ready to land.May 20 2021, 2:30 PM

anlambert added inline comments.May 20 2021, 2:33 PM

Makefile.local
100–102	Yes it is, my plan is to use `webpack-dev-server` when running cypress tests. This way we can hack into `swh-web` javascript code without having to relaunch cypress to take the changes into account. I will add a new background process in that command in a future diff so that change.

Rebase

Build is green

Patch application report for D5760 (id=20602)

Rebasing onto 7506c2d4e7...

Current branch diff-target is up to date.

Changes applied before test

commit 33daf4c007a279bf4d0d64fd62f3e0bbe696998c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu May 20 13:52:56 2021 +0200

    Makefile.local: Wrap long lines

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/842/ for more details.

Harbormaster completed remote builds in B21566: Diff 20602.May 20 2021, 3:44 PM

Closed by commit rDWAPPS33daf4c007a2: Makefile.local: Wrap long lines (authored by anlambert). · Explain WhyMay 20 2021, 3:51 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS33daf4c007a2: Makefile.local: Wrap long lines.