Differential D5756

templates/layout: Display swh-web version and add development ribbon
ClosedPublic
Actions

Authored by anlambert on May 19 2021, 5:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS5adccbb354be: templates/layout: Display swh-web version and add development ribbon

Summary

Display current swh-web version at the bottom of the footer.

In development mode, add a ribbon similar to the one used in staging
to not confuse with the production webapp.

Add swh-web version in ribbon.

Diff Detail

Repository

rDWAPPS Web applications

Branch

swh-web-display-version

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 21546
Build 33474: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 33473: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Jenkins > should be visible when scrolled down::Tests / Cypress tests / Run cypress tests / Back-to-top button tests should be visible when scrolled down AssertionError: Timed out retrying after 20000ms: expected '<div#back-to-top>' to be 'visible' This element `<div#back-to-top>` is not visible because it has CSS property: `display: none`
	0 ms	Jenkins > should be visible when scrolled down::Tests / Cypress tests / Run cypress tests / Back-to-top button tests should be visible when scrolled down AssertionError: Timed out retrying after 20000ms: expected '<div#back-to-top>' to be 'visible' This element `<div#back-to-top>` is not visible because it has CSS property: `display: none`
	0 ms	Jenkins > should report SWHID with uppercase chars in top right search input::Tests / Cypress tests / Run cypress tests / Test origin-search Test invalid SWHIDs should report SWHID with uppercase chars in top right search input CypressError: Timed out retrying after 20050ms: `cy.click()` failed because this element: `<i class="swh-search-icon mdi mdi-24px mdi-magnify" aria-hidden="true"></i>`
	0 ms	Jenkins > should report SWHID with uppercase chars in top right search input::Tests / Cypress tests / Run cypress tests / Test origin-search Test invalid SWHIDs should report SWHID with uppercase chars in top right search input CypressError: Timed out retrying after 20050ms: `cy.click()` failed because this element: `<i class="swh-search-icon mdi mdi-24px mdi-magnify" aria-hidden="true"></i>`
	0 ms	Jenkins > should report invalid SWHID in top right search input::Tests / Cypress tests / Run cypress tests / Test origin-search Test invalid SWHIDs should report invalid SWHID in top right search input CypressError: Timed out retrying after 20050ms: `cy.click()` failed because this element: `<i class="swh-search-icon mdi mdi-24px mdi-magnify" aria-hidden="true"></i>`
		View Full Test Results (8 Failed · 1,362 Passed · 10 Skipped)

Event Timeline

anlambert created this revision.May 19 2021, 5:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 19 2021, 5:33 PM

Build has FAILED

Patch application report for D5756 (id=20571)

Rebasing onto 15256c55d7...

Current branch diff-target is up to date.

Changes applied before test

commit a6a0f5994b486847b5f7aa0702523c557a5490e8
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed May 19 16:28:00 2021 +0200

    templates/layout: Display swh-web version and add development ribbon
    
    Display current swh-web version at the bottom of the footer.
    
    In development mode, add a ribbon similar to the one used in staging
    to not confuse with the production webapp.
    
    Add swh-web version in ribbon.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/832/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/832/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 19 2021, 5:43 PM

Harbormaster failed remote builds in B21546: Diff 20571!

Build has FAILED

Patch application report for D5756 (id=20571)

Rebasing onto 15256c55d7...

Current branch diff-target is up to date.

Changes applied before test

commit a6a0f5994b486847b5f7aa0702523c557a5490e8
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed May 19 16:28:00 2021 +0200

    templates/layout: Display swh-web version and add development ribbon
    
    Display current swh-web version at the bottom of the footer.
    
    In development mode, add a ribbon similar to the one used in staging
    to not confuse with the production webapp.
    
    Add swh-web version in ribbon.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/833/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/833/console

Fix cypress tests

Build is green

Patch application report for D5756 (id=20575)

Rebasing onto 15256c55d7...

Current branch diff-target is up to date.

Changes applied before test

commit 5adccbb354beabde97d1bf72b0ecf6f6b9dcc34f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed May 19 16:28:00 2021 +0200

    templates/layout: Display swh-web version and add development ribbon
    
    Display current swh-web version at the bottom of the footer.
    
    In development mode, add a ribbon similar to the one used in staging
    to not confuse with the production webapp.
    
    Add swh-web version in ribbon.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/834/ for more details.

Harbormaster completed remote builds in B21550: Diff 20575.May 19 2021, 6:53 PM

anlambert requested review of this revision.May 19 2021, 6:53 PM

ardumont accepted this revision.May 19 2021, 8:15 PM

This revision is now accepted and ready to land.May 19 2021, 8:15 PM

Closed by commit rDWAPPS5adccbb354be: templates/layout: Display swh-web version and add development ribbon (authored by anlambert). · Explain WhyMay 20 2021, 11:12 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS5adccbb354be: templates/layout: Display swh-web version and add development ribbon.