tox
Details
Details
- Reviewers
douardda anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS3d95c0667bf9: Save code now: Improve save request task information title
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20996 Build 32587: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 32586: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D5592 (id=19998)
Could not rebase; Attempt merge onto 1ca5105c4e...
Updating 1ca5105c..3d95c066 Fast-forward assets/src/bundles/save/index.js | 4 +- swh/web/common/management/__init__.py | 0 swh/web/common/management/commands/__init__.py | 0 .../commands/refresh_savecodenow_statuses.py | 22 ++++++ swh/web/common/models.py | 37 ++++++---- swh/web/common/origin_save.py | 84 ++++++++++++++-------- swh/web/common/typing.py | 23 +++++- swh/web/misc/origin_save.py | 7 +- swh/web/tests/common/test_django_command.py | 35 +++++++++ swh/web/tests/common/test_origin_save.py | 72 ++++++++++++++++++- 10 files changed, 232 insertions(+), 52 deletions(-) create mode 100644 swh/web/common/management/__init__.py create mode 100644 swh/web/common/management/commands/__init__.py create mode 100644 swh/web/common/management/commands/refresh_savecodenow_statuses.py create mode 100644 swh/web/tests/common/test_django_command.py
Changes applied before test
commit 3d95c0667bf9708e55bd3b9f28722532a4c0f689 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Apr 26 15:33:47 2021 +0200 Save code now: Improve save request task information title commit f92c78719a9a8a0d2acdc622efc346f7a9b07030 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Fri Apr 23 10:21:24 2021 +0200 Separate save code now status refresh routine from the listing ui This introduces a new endpoint to refresh the status of the save code now requests. This endpoint will be called periodically. That concern is out of scope of the listing ui and source of status update desynchronization [1] The listing ui now feels more immediate as implementation wise, it no longer writes when actually listing rows. This slightly improves the code by typing it a bit more. A new SaveOriginRequestInfo got added to represent the save origin request to display view side. This matches what other views manipulates. [1] T3278#63827 Related to T3280
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/734/ for more details.