I did it, it caused closed cursors that hang the process,
that's hard to debug.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSTOCa8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't.
R65:a8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't.
rDSTOa8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- db-transaction
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1709 Build 2055: tox-on-jenkins Jenkins Build 2054: arc lint + arc unit
Event Timeline
Comment Actions
lgtm.
Tested and worked as entertained:
# patch the storage locally arc patch D556 make test # all is green # open swh.storage.storage.py # replace @db_transaction_generator from content_get_metadata (randomly chosen as the first one with such decorator ;) make test # This fails with the error mentioned for content_get_metadata ( # revert the modification # change content_update to @db_transaction (`use db_transaction_generator for generator function`). make test # This fails on content_update with the error mentioned (`use db_transaction for non-generator function`)
Thanks.